Repository navigation
fix(dashboard): clean up reconnects, report control failures, and add CI - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing an unmounted metrics socket could schedule a new reconnect, including during React StrictMode remounts. Each effect now owns its socket/timer, ignores stale callbacks, validates incoming snapshots, bounds history, and resets history after policy changes or server restarts.
Show failed mode-change requests, disable duplicate/inapplicable submissions, use runtime policy labels, fix negative advantage formatting, and label the alpha slider. Add dashboard lint/test/build CI and apply compatible dependency security updates; npm audit now reports zero vulnerabilities.
Validation: six Vitest/Testing Library tests covering StrictMode, stale close callbacks, reconnection cleanup, malformed metrics, bounded history, and failed mode requests; npm run lint; npm run build; npm audit. The production build retains a non-fatal bundle-size advisory.
This PR is stacked on #14 because the current CI Rust compiler rejects the original load-generator division code. Merge #14 first; the diff here contains only this improvement family.
Replaces #12 after removing the codex/ branch prefix. Commit contents are preserved; the original PR retains prior discussion and review history.