Better Management of Signature schemes - #43
Open
CryptoPascal31 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supersedes
#19
which was a quick&dirty proof of concept.
To prepare for the arrival of Post-Quantum signatures..
At this point, It's supposed to not change any behavior, and the chain is supposed to be replayable.
The PR improves the management of Allowed Signature schemes, and generalize the mechanism used for Pact4 to Pact5:
Manage allowed schemes using the "Rules" mechanism.
Instead of passing list of schemes, use now a validator function
(PPKScheme -> Bool), giving more flexibility.Port the mechanism from Pact 4 to Pact 5
use a new data type to generalize signature schemes management:
data GenericPPKScheme = SchemeV4 Pact4.PPKScheme | SchemeV5 Pact5.PPKSchemeIn the same time, I factored a little bit Rules descriptions in versions (
afterForkfunction), and reformatted rules to nicely show the "Above" concept..Note: I had to temporarily disable some Benchmarks... This will be fixed in another PR. The tests routines are a little bit messy, and mix some Pact4 with Pact5 dedicated functions. It needs a cleaning pass, to make everything consistent.