Repository navigation
Expand scalar model imports with verified function semantics - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Models using simulation bounds, inverse trig spellings and supported Vensim functions previously failed import or execution. Add run-bound STARTTIME/STOPTIME values and calls; inverse-trig XMILE roundtrips; distinct integer, safe-division and signed-remainder operations; and ten additional MDL function spellings with exact arity and retained source.
Preserve declared-name/table ownership, per-run settings isolation and existing finite/domain checks. Extend dimensional checks and conservative Radau discontinuity guards. Reference documentation distinguishes pinned Simlin source from the executed 0.8.5 wheel, records dialect disagreements, and lists unsupported stateful/import features rather than claiming universal parity.
Validation: frozen public suite 3,433 passed plus 18 subtests, no xfails/skips; all 1,000 existing complete trajectories and model files unchanged; clean public full-library audit 1,000 passed. Independent reference comparisons, 24 concurrent override runs, 11 release-helper safety tests and exact-source real HTTP/MCP/MDL saved roundtrips plus identifier/namespace/array/sensitivity acceptance passed locally. CI and production-dependency staging remain pending. No model definitions, dependencies, configuration or UI paths changed.