Skip to content

Preserve scalar model results across XMILE import and export - #16

Open
keptlive wants to merge 2 commits into
mainfrom
codex/expression-roundtrip-fixes-20261024
Open

keptlive wants to merge 2 commits into
mainfrom
codex/expression-roundtrip-fixes-20261024

Conversation

@keptlive

@keptlive keptlive commented Oct 24, 2026 •

Copy link
Copy Markdown
Owner

Fix expression and import behavior that prevented executable scalar models from surviving XMILE export/reimport. Preserve lookup ownership, seeded random-call identities, report outputs, solver tolerances, discrete periods and reserved names through an explicit native-scalar-v1 extension profile. Add MOD, variadic MIN/MAX and RANDOM_BINOMIAL export support, and correct STEP grid rounding, negative-start RAMP, Vensim RAMP import, quoted MDL identifiers and Radau discontinuity admission.

Release is on hold while the remaining expression/compatibility inventory and focused fixes are completed. The two full CI runs for b9d2d78 were intentionally cancelled; this branch is not merged or deployed. The earlier ff6d376 CI failures were four obsolete rejection assertions, now replaced by reviewed numerical roundtrip checks.

Completed evidence: all 1,000 public models pass full default simulation and exact export/reimport trajectory/settings/report/role comparison for the recorded engine; complete default trajectories are unchanged from the previous release. Actual HTTP/MCP acceptance covers saved imports, solver/report/random metadata and malformed inputs without persistence. The library roundtrip audit runs through existing pytest CI and checks source inventory/byte hashes. A final complete acceptance run will follow completion of focused compatibility work.

The recorded source-built Simlin comparison has ten exact local roundtrips: eight reference agreements, one signed-remainder difference and one standalone-table reader rejection. The reference includes our proposed upstream safe-division fix; this is not a universal parity claim. Native extensions require compatible readers; structured arrays/modules currently require JSON export.

No model definitions, UI, dependencies or production data are changed. Any eventual runtime deployment must be reviewed and restricted to exact approved files, preserving production-only models and the database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant