Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix expression and import behavior that prevented executable scalar models from surviving XMILE export/reimport. Preserve lookup ownership, seeded random-call identities, report outputs, solver tolerances, discrete periods and reserved names through an explicit native-scalar-v1 extension profile. Add MOD, variadic MIN/MAX and RANDOM_BINOMIAL export support, and correct STEP grid rounding, negative-start RAMP, Vensim RAMP import, quoted MDL identifiers and Radau discontinuity admission.
Release is on hold while the remaining expression/compatibility inventory and focused fixes are completed. The two full CI runs for b9d2d78 were intentionally cancelled; this branch is not merged or deployed. The earlier ff6d376 CI failures were four obsolete rejection assertions, now replaced by reviewed numerical roundtrip checks.
Completed evidence: all 1,000 public models pass full default simulation and exact export/reimport trajectory/settings/report/role comparison for the recorded engine; complete default trajectories are unchanged from the previous release. Actual HTTP/MCP acceptance covers saved imports, solver/report/random metadata and malformed inputs without persistence. The library roundtrip audit runs through existing pytest CI and checks source inventory/byte hashes. A final complete acceptance run will follow completion of focused compatibility work.
The recorded source-built Simlin comparison has ten exact local roundtrips: eight reference agreements, one signed-remainder difference and one standalone-table reader rejection. The reference includes our proposed upstream safe-division fix; this is not a universal parity claim. Native extensions require compatible readers; structured arrays/modules currently require JSON export.
No model definitions, UI, dependencies or production data are changed. Any eventual runtime deployment must be reviewed and restricted to exact approved files, preserving production-only models and the database.