Repository navigation
Conversation
Add an optional executor parameter to execute_playwright_code, surface the tab page was bound to in its result, and report the current executors when the browser is at its named executor limit. Add manage_playwright_executors with list and delete actions. Point @onkernel/sdk at a vendored preview build that includes the executors surface.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Replace the vendored preview tarball with the published package that includes the Playwright executors surface.
rgarcia
force-pushed
the
hypeship/playwright-executors
branch
from
October 6, 2026 22:44
2a5368c to
8b6b5b0
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8503898. Configure here.
| "Calls without 'executor' run in the executor named 'default', which always exists and is the same as passing 'executor: \"default\"'. In the default executor, 'page' is bound to an active tab reported by Chrome. In single-window sessions, this is the foreground tab. When multiple browser windows are open, Chrome reports one active tab per window and the selected window is unspecified. 'context' is the BrowserContext that owns the selected page. Use 'browser.contexts()' to select a context or page explicitly.\n\n" + | ||
| "Pass any other name to run the call in a named executor. The first call with a new name creates it. Each named executor owns a tab: its first call opens a new background tab in the default browser context, and 'page' is bound to that tab on every later call while it stays open. Opening it does not change the active tab of an existing window. If the tab is closed, the next call opens a new one and reports 'tab.created: true'. Executor code can still reach other tabs through 'context' and 'browser'; ownership only decides what 'page' is bound to. Use named executors to drive several tabs of one browser in parallel.\n\n" + | ||
| "A browser can have at most 8 named executors; the default executor does not count. A call that would create another fails with an error listing the current executors; delete one with manage_playwright_executors (action 'delete'). Named executors are not removed automatically while the browser runs; when it shuts down, they are removed and their tabs closed.\n\n" + | ||
| "A named call to a browser whose image predates executors fails with an error instead of running on the active tab; calls without 'executor' keep working on every image.", |
There was a problem hiding this comment.
Tool description drops WebMCP preference
Medium Severity
The rewritten execute_playwright_code description no longer tells agents to check webmcp.listTools() first and prefer a suitable structured tool, using Playwright only when none is exposed. The new text only mentions the in-process helpers, so tool selection no longer steers toward WebMCP or the empty-catalog fallback.
Triggered by learned rule: WebMCP: describe() guidance for tool_ref, empty catalog, outcome_unknown
Reviewed by Cursor Bugbot for commit 8503898. Configure here.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds named Playwright executor support to the MCP server, matching the browser API's executor surface.
execute_playwright_codegains an optionalexecutorparameter (^[A-Za-z0-9_-]{1,64}$), passed to the SDK only when set. Omitting it (or passingdefault) keeps today's behavior:pageis bound to the active tab. Any other name runs the call in a named executor that owns its own background tab, so independent tasks can run in parallel in separate tabs of one browser while calls on the same executor stay serialized.tab(target_id,created) when the API reports the tabpagewas bound to.manage_playwright_executorstool in theplaywrighttoolset withlistanddeleteactions.deletetakesnameand an optionalclose_tab(default true); deletingdefaultrestarts it instead of removing it.tool-names.tsand the registration tests include the new tool.Dependencies
Depends on
@onkernel/sdk0.120.0 (released), which includesbrowsers.playwright.executorsand theexecutor/tabfields on execute.package.jsonis bumped to"@onkernel/sdk": "0.120.0"and the lockfile change is limited to that dependency.Tests
src/lib/mcp/tools/playwright.test.tscovers executor passthrough, name validation,tabin the result, the 409 limit error, and list/delete (defaultclose_tab, explicitclose_tab: false,defaultrestart wording, missing name, API 404).bunx tsc --noEmit --incremental false,bun test(902 pass), andbun run check:managed-auth-apppass locally.bun run format:checkreports only a pre-existing issue inAGENTS.md, which this PR does not touch.