Use public suffix list for auth site labels - #38
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
chruffins
marked this pull request as ready for review
October 5, 2026 19:42
akxue
approved these changes
Oct 5, 2026
akxue
left a comment
akxue
left a comment
There was a problem hiding this comment.
cool, this seems like a super cool and useful library for us - lgtm
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Note
Low Risk
Display-only hostname labeling change with tests; no auth or data-handling logic touched.
Overview
Site labels on the initial auth screen (e.g. in
StepPrimeandSiteIcon) now come from public-suffix–aware parsing instead of a fixed list of multi-part TLDs.extractPrimaryDomainLabelinprofile-name.tsis rewritten to usetldtsso subdomains likelogin.clalit.co.ilandauth.example.co.ukresolve to clalit / example rather than wrong segments. The package addstldts@7.4.15, unit tests for those cases, and a patch changeset for@onkernel/managed-auth-react.Reviewed by Cursor Bugbot for commit 06c901b. Configure here.