Handle unknown search result kinds without throwing #226 - #227
Merged
Merged
Conversation
…ogue-work fix issues 226
Owner
|
@JbravoI thanks for the contribution, I'll get this merged in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an edge case in issue #226 where the search response converter throws NotImplementedException when Companies House introduces an unrecognised search result kind.
Changes
UnknownSearchItemas a generic fallback model.SearchItemConverterto deserialize unknown kind values into UnknownSearchItem.kindvalue for callers.Why
Companies House may add new search result types over time. Deserialization should remain forward-compatible instead of failing the entire response when an unfamiliar
kindis returned.Testing
Added scenario test:
SearchAllPayload_DeserializesUnknownKindAsGenericSearchItemThe test verifies that: