Skip to content

Bump SourceLink to remove vulnerable Microsoft.Build.Tasks.Git restore path - #228

Merged
kevbite merged 2 commits into
masterfrom
copilot/fix-package-restore-errors
Sep 11, 2026
Merged

kevbite merged 2 commits into
masterfrom
copilot/fix-package-restore-errors

Conversation

Copilot AI commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Restore was failing with NU1902 because Microsoft.Build.Tasks.Git 8.0.0 (transitive) is flagged as vulnerable and warnings are treated as errors. The failure impacted package restore for both core and DI projects.

  • Dependency baseline update

    • Updated central package versioning in Directory.Packages.props:
      • Microsoft.SourceLink.GitHub 8.0.0 → 10.0.401
    • This advances the SourceLink toolchain and removes resolution to vulnerable Microsoft.Build.Tasks.Git 8.0.0.
  • Scope of change

    • Single-file, central version change only.
    • No project-level package reference shape changes.
<!-- Directory.Packages.props -->
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="10.0.401" />

Co-authored-by: kevbite <5544715+kevbite@users.noreply.github.com>
Co-authored-by: kevbite <5544715+kevbite@users.noreply.github.com>
@kevbite
kevbite marked this pull request as ready for review September 11, 2026 14:35
Copilot AI lite review requested due to automatic review settings September 11, 2026 14:35
@kevbite
kevbite merged commit d8cf9a2 into master Sep 11, 2026
2 checks passed
@kevbite
kevbite deleted the copilot/fix-package-restore-errors branch September 11, 2026 14:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Document the additional test-file change in the PR description or commit rationale.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates SourceLink to remove a vulnerable transitive build dependency and adds a required test namespace import.

Changes:

  • Bumps Microsoft.SourceLink.GitHub to 10.0.401.
  • Adds the CompaniesHouse.Response.Search namespace import.
File summaries
File Description
tests/CompaniesHouse.ScenarioTests/SearchResponseDeserializationScenarioTests.cs Adds the namespace required by the test.
Directory.Packages.props Updates the centrally managed SourceLink version.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

using CompaniesHouse.Response;
using CompaniesHouse.Response.Search.AdvancedCompanySearch;
using CompaniesHouse.Response.Search.AllSearch;
using CompaniesHouse.Response.Search;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants