Bump SourceLink to remove vulnerable Microsoft.Build.Tasks.Git restore path - #228
Merged
Merged
Conversation
Co-authored-by: kevbite <5544715+kevbite@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
kevbite
September 11, 2026 11:18
View session
kevbite
self-requested a review
September 11, 2026 11:18
Co-authored-by: kevbite <5544715+kevbite@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Document the additional test-file change in the PR description or commit rationale.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates SourceLink to remove a vulnerable transitive build dependency and adds a required test namespace import.
Changes:
- Bumps
Microsoft.SourceLink.GitHubto10.0.401. - Adds the
CompaniesHouse.Response.Searchnamespace import.
File summaries
| File | Description |
|---|---|
tests/CompaniesHouse.ScenarioTests/SearchResponseDeserializationScenarioTests.cs |
Adds the namespace required by the test. |
Directory.Packages.props |
Updates the centrally managed SourceLink version. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| using CompaniesHouse.Response; | ||
| using CompaniesHouse.Response.Search.AdvancedCompanySearch; | ||
| using CompaniesHouse.Response.Search.AllSearch; | ||
| using CompaniesHouse.Response.Search; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore was failing with
NU1902becauseMicrosoft.Build.Tasks.Git8.0.0(transitive) is flagged as vulnerable and warnings are treated as errors. The failure impacted package restore for both core and DI projects.Dependency baseline update
Directory.Packages.props:Microsoft.SourceLink.GitHub8.0.0→10.0.401Microsoft.Build.Tasks.Git8.0.0.Scope of change