Repository navigation
fix(frigate): live camera pictures in the panel, a working Web UI link, and one login at a time (1.2.0) - #792
Merged
Merged
Conversation
…k, and one login at a time (1.2.0) Seen on a phone: the panel showed no picture, its Web UI tab iframed http://localhost:8971 (the phone itself, blocked by CSP), and parallel logins tripped Frigate's 1/second login limit, which the client reported as wrong credentials. The Overview now shows each camera's latest picture through the gateway's authenticated route, refreshed every 2 s while visible; the Web UI tab links to FRIGATE_UI_URL (e.g. a Tailscale Serve address) in a new tab and never renders the loopback address; both login paths share one in-flight login and retry a 429. config.yml.example turns detection on (Frigate 0.18 needs it). Claude-Session: https://claude.ai/code/session_01N9fXzvNy8rCEArj1y5p6fp
…e first picture, no overlapping loads, damped failed logins (review) Claude-Session: https://claude.ai/code/session_01N9fXzvNy8rCEArj1y5p6fp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frigate bundle 1.2.0. Fixes three problems seen when using the Frigate panel from a phone.
What changes
Live pictures in the panel. Each camera card on the Overview shows the camera's latest picture through the gateway's authenticated route (
/api/frigate/<camera>/latest.jpg, sent withno-store).windowstate, andturbo:before-cacheandturbo:before-visitstop them.A working Web UI tab. The tab used to iframe
FRIGATE_URL(http://localhost:8971), which a phone resolves to itself, so it was blocked. It now offers a new-tab link to a new optionalFRIGATE_UI_URL(for example a Tailscale Serve HTTPS address), showing only its origin as text. Only http(s) is accepted, and the loopback address is never rendered.One login at a time. Parallel requests tripped Frigate's 1-per-second login limit, and the client reported that as wrong credentials. Both login paths (
server/frigate-api.jsandpanel/routes.js) now:A rate-limit error now has its own message.
Example config:
config.yml.exampleturns detection on per camera, which Frigate 0.18 needs.Docs and registry: the docs (en and es), the registry entry, and a port-allocation row for a tailnet Serve port used for the Frigate UI.
Tests
tests/frigate-panel.test.jscovers:FRIGATE_UI_URL, including that the loopback address never renders;Result: 248 pass, 0 fail in the sandboxed runner, together with the bundle contract, server-deps, installed-copy and add-on widget tests. The port check and the public hygiene check pass.
Review
A sonnet review asked for six fixes (the Turbo timer leak, a stale first picture, overlapping loads, damped failed logins, origin-only text, and a trailing newline). All six are in the second commit, and a scoped re-review approved.
Implemented by the Pi coding agent from controller briefs.
https://claude.ai/code/session_01N9fXzvNy8rCEArj1y5p6fp