docs(adr): the toggle is declined and localisation is deferred — all four accepted - #79
Merged
Merged
Conversation
…four accepted The owner declined the manual theme toggle (ADR-032 §3) and deferred localisation (ADR-033 §4) on 2026-09-27. With ADR-030 and ADR-031 already accepted, all four ADRs from the frontend audit are now decided and **nothing in the roadmap waits on a decision.** Both ADRs record what acceptance does *not* mean, because that is where a document starts overstating itself: - **ADR-032** settles the theme mechanism — one media query, semantic tokens, no stored preference, and a test that fails if a `data-theme` selector appears. It does not close roadmap A4: nobody has looked at a dark-mode scrollbar or an autofilled field. And declining the toggle is not forbidding one — a real user request supersedes the ADR, and §3 records the cost so that conversation starts from a number. - **ADR-033** defers the interface language. It does **not** license writing English-only assumptions into the code, which is the whole point of §2's habit, and it does not close §3: `<track>` still lacks `srclang` and `label`. That is a defect rather than a decision and it is blocked on backend modelling, because the correct value is not knowable from the frontend. Deferring the interface language and failing to say what language the captions are in are different problems and only one of them is settled. **The practice worth keeping is recorded in STATUS.** Both of these ADRs were split before being decided, each having mixed "this is broken" with "what should we do" — and the broken half never needed the decision. `color-scheme` and the logical properties shipped hours ahead of the questions they had been sitting behind. When an ADR contains both, split it. The defect table is rewritten by state rather than by count: two fixed, one open, one blocked, plus a fifth found while fixing the fourth. It also keeps the corrections — measurement disproved part of ADR-032 §2, because Tailwind's Preflight already resets form controls; and ADR-033's "about four" utilities were nine. Docs only. 425 frontend tests still pass, unchanged. Every ADR id and doc path resolves, and no document still describes any of the four as proposed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The owner declined the manual theme toggle (ADR-032 §3) and deferred localisation (ADR-033 §4). With ADR-030 and ADR-031 already accepted, all four ADRs from the frontend audit are decided and nothing in the roadmap waits on a decision.
Docs only, four files.
<track>gap, blocked on backendBoth ADRs say what acceptance does not mean
That's where a document starts overstating itself.
ADR-032 settles the mechanism — one media query, semantic tokens, no stored preference, a test that fails if a
data-themeselector appears. It does not close roadmap A4: nobody has looked at a dark-mode scrollbar or an autofilled field. And declining the toggle isn't forbidding one — a real user request supersedes the ADR, and §3 records the cost so that conversation starts from a number rather than an impression.ADR-033 defers the interface language. It does not license writing English-only assumptions into the code — that's the whole point of §2's habit — and it does not close §3.
<track>still lackssrclangandlabel; that's a defect rather than a decision, blocked on backend modelling because the correct value isn't knowable from the frontend. Deferring the interface language and failing to say what language the captions are in are different problems, and only one is settled here.The practice worth keeping
Both of these ADRs were split before being decided. Each mixed "this is broken" with "what should we do", and the broken half never needed the decision —
color-schemeand the logical-property swaps shipped hours ahead of the questions they'd been sitting behind.When an ADR contains both, split it. That's recorded in STATUS rather than left as a thing that happened once.
The defect table is rewritten by state, not count
Two fixed, one open, one blocked — plus a fifth found while fixing the fourth. It keeps the corrections rather than quietly dropping them: measurement disproved part of ADR-032 §2 (Tailwind's Preflight already resets form controls, so those were never affected), and ADR-033's "about four" utilities were actually nine.
Still true, and still needs a person
Section A of the roadmap — five verification items — needs a browser, not an agent. Top of that list, outstanding since 2026-09-25: open
/with reduced motion enabled and confirm the headline appears. Ten minutes, and the only unverified claim from four stages of redesign.425 frontend tests unchanged. Every ADR id and doc path resolves, and no document still describes any of the four as proposed.
🤖 Generated with Claude Code