Repository navigation
Bundle store-tcs.properties as package data and pass via --store-tcs to all getscu calls - #65
Merged
akhanf merged 3 commits intoJul 14, 2026
Conversation
for physiolog download
akhanf
marked this pull request as ready for review
July 14, 2026 17:46
akhanf
deleted the
copilot/update-getscu-calls-to-use-store-tcs-properties
branch
July 14, 2026 17:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
store-tcs.propertieswas previously provided by thedcm4che-toolsconda package, making it fragile to update and unavailable in non-conda installs. This bundles the file directly in the Python package and wires it into everygetscuinvocation.Changes
cfmm2tar/data/store-tcs.properties— Copies the file fromshare/dcm4che/etc/getscu/into the package so it's included as wheel/editable package datacfmm2tar/dcm4che_utils.py— Resolves the bundled file path at module load viaimportlib.resources; appends--store-tcs <path>to_getscu_strin_build_commandstests/test_dcm4che_utils.py— Asserts--store-tcsandstore-tcs.propertiesappear in_getscu_strThe resolved path is set once at module import:
And injected into every
getscucommand: