Repository navigation
fix(deps): bump dependencies and add sharp override for vulnerability fixes - #229
roely15mol wants to merge 1 commit into
Conversation
…ner vulnerabilities
|
Thanks for the contribution and for flagging these security findings! After reviewing the changes, I don’t think we should merge this PR as-is:
For the bundled sharp dependencies, I’d prefer to pursue a fix in the upstream Desktop/plugin packaging pipeline, then adopt and validate the corrected artifact here. This doesn’t mean the scanner findings are invalid—only that the override in this PR doesn’t address them. If you’d like to continue with the Thanks again for bringing this to our attention! |
|
Thanks again for the thorough review, @kingsword09 — all points taken. Closing this in favor of the split-out work:
Happy to help validate a corrected Desktop artifact with our Trivy setup whenever one is available. |
Hi @kingsword09,
First off, thank you for creating and maintaining this project! We really enjoy using the ZCode CLI in our developer workflows and sandboxed agent environments.
While running security scans with Trivy against container installations, we encountered vulnerability findings stemming from older bundled sub-dependencies:
sharp(0.34.5) flagsGHSA-rgj7-g3m4-5g8c,GHSA-wq5f-xc86-pv6w, andGHSA-f88m-g3jw-g9cj(libheif/librsvg/libvips CVEs). Adding an override for"sharp": ">=0.35.5"(matching the existingundicioverride pattern inpackage.json) resolves these scanner errors.@earendil-works/pi-tui:^1.3.0->^1.4.0yaml:^2.8.1->^2.9.0acorn:^8.15.0->^8.18.0Validation:
bun run typecheckpasses cleanlybun run buildsucceedsbun.lockupdated cleanly viabun installThanks again for the great work on
zcode-cli!