Skip to content

feat(sdk): expose a shared log viewer panel and stream lifecycle - #3

Merged
zxh326 merged 2 commits into
mainfrom
codex/sdk-aggregated-log-support
Nov 14, 2026
Merged

zxh326 merged 2 commits into
mainfrom
codex/sdk-aggregated-log-support

Conversation

@zxh326

@zxh326 zxh326 commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Plugins that manage log streams now use LogViewerPanel, the same presentation component used by Kite's native Pod viewer. The existing LogViewer remains responsible for Pod subscriptions and requires a namespace.

  • Add LogViewerPanelProps and LogViewerEntry with stable IDs, ANSI text, and optional Unix millisecond timestamps. The host formats timestamps in the browser's local timezone.
  • Provide toolbar, header, settings, status, clear/close, download filename, and initial theme props for the shared panel.
  • Add follow, onStreamError, and onStreamEnd to LogsWebSocketOptions.
  • Export Kite's Popover component types and add their Radix peer dependency.

This replaces the unreleased dual-mode LogViewer contract. Host implementation: kite-org/kite#792. The aggregated-logs plugin and generated packages are excluded and remain local; package versions are unchanged.

Validation passed: pnpm run type-check (SDK and all existing plugins), pnpm run lint, and pnpm run format:check. The local aggregated-logs plugin also builds and packages with the new declarations.

Summary by CodeRabbit

  • New Features
    • The plugin SDK now provides popover components and a log viewer panel with customizable entries, display content, themes, download filenames, and clear or close actions.
    • Log streaming options now support following new logs and callbacks for stream errors and completion.

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The plugin SDK adds Popover declarations and a Radix Popover peer dependency. It also adds public types for the log viewer and new WebSocket stream options.

Changes: Plugin SDK API

Layer / File(s) Summary
Popover dependency and declarations
packages/plugin-sdk/package.json, packages/plugin-sdk/src/ui.ts
The SDK adds @radix-ui/react-popover as a peer dependency and exports component types for the Popover root, trigger, and content.
Log viewer and stream options
packages/plugin-sdk/src/ui.ts, packages/plugin-sdk/src/observability.ts
The SDK adds LogViewerEntry and LogViewerPanelProps, exports LogViewerPanel, and adds follow, onStreamError, and onStreamEnd to LogsWebSocketOptions.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Merge Risk: Minimal · up to d7206

This change adds type declarations for plugin-managed log viewers and Popover components, plus a peer dependency. It does not change runtime behavior in this repository. The matching Kite host implementation is delivered separately and should ship before plugins start using the new panel. No merge-blocking risk is evident here.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the two main additions in the changeset: a shared log viewer panel (LogViewerPanel, LogViewerEntry, LogViewerPanelProps in ui.ts) and stream lifecycle (follow, onStreamError, onStreamE…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title names the two main additions in the changeset: a shared log viewer panel (LogViewerPanel, LogViewerEntry, LogViewerPanelProps in ui.ts) and stream lifecycle (follow, onStreamError, onStreamEnd in LogsWebSocketOptions). The title's scope prefix matches the plugin-sdk package. The PR also exports Popover types and adds a Radix peer dependency, which the title does not mention, but those are supporting changes and not the main point.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: eedbf2ef-0cc4-4e94-85bb-fdedc4883058
Commits

Reviewing files that changed from the base of the PR and between c6b0e73 and d720676.

Files selected for processing: 1

  • packages/plugin-sdk/src/ui.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@zxh326 zxh326 changed the title feat(sdk): support plugin-managed log viewers feat(sdk): expose a shared log viewer panel and stream lifecycle Nov 14, 2026
@zxh326
zxh326 merged commit 5a6c128 into main Nov 14, 2026
2 checks passed
@zxh326
zxh326 deleted the codex/sdk-aggregated-log-support branch November 14, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant