You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(sdk): expose a shared log viewer panel and stream lifecycle - #3
Plugins that manage log streams now use LogViewerPanel, the same presentation component used by Kite's native Pod viewer. The existing LogViewer remains responsible for Pod subscriptions and requires a namespace.
Add LogViewerPanelProps and LogViewerEntry with stable IDs, ANSI text, and optional Unix millisecond timestamps. The host formats timestamps in the browser's local timezone.
Provide toolbar, header, settings, status, clear/close, download filename, and initial theme props for the shared panel.
Add follow, onStreamError, and onStreamEnd to LogsWebSocketOptions.
Export Kite's Popover component types and add their Radix peer dependency.
This replaces the unreleased dual-mode LogViewer contract. Host implementation: kite-org/kite#792. The aggregated-logs plugin and generated packages are excluded and remain local; package versions are unchanged.
Validation passed: pnpm run type-check (SDK and all existing plugins), pnpm run lint, and pnpm run format:check. The local aggregated-logs plugin also builds and packages with the new declarations.
Summary by CodeRabbit
New Features
The plugin SDK now provides popover components and a log viewer panel with customizable entries, display content, themes, download filenames, and clear or close actions.
Log streaming options now support following new logs and callbacks for stream errors and completion.
No actionable comments were generated in the recent review.
Walkthrough
The plugin SDK adds Popover declarations and a Radix Popover peer dependency. It also adds public types for the log viewer and new WebSocket stream options.
Changes: Plugin SDK API
Layer / File(s)
Summary
Popover dependency and declarations packages/plugin-sdk/package.json, packages/plugin-sdk/src/ui.ts
The SDK adds @radix-ui/react-popover as a peer dependency and exports component types for the Popover root, trigger, and content.
Log viewer and stream options packages/plugin-sdk/src/ui.ts, packages/plugin-sdk/src/observability.ts
The SDK adds LogViewerEntry and LogViewerPanelProps, exports LogViewerPanel, and adds follow, onStreamError, and onStreamEnd to LogsWebSocketOptions.
This change adds type declarations for plugin-managed log viewers and Popover components, plus a peer dependency. It does not change runtime behavior in this repository. The matching Kite host implementation is delivered separately and should ship before plugins start using the new panel. No merge-blocking risk is evident here.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the two main additions in the changeset: a shared log viewer panel (LogViewerPanel, LogViewerEntry, LogViewerPanelProps in ui.ts) and stream lifecycle (follow, onStreamError, onStreamE…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check
Explanation
The title names the two main additions in the changeset: a shared log viewer panel (LogViewerPanel, LogViewerEntry, LogViewerPanelProps in ui.ts) and stream lifecycle (follow, onStreamError, onStreamEnd in LogsWebSocketOptions). The title's scope prefix matches the plugin-sdk package. The PR also exports Popover types and adds a Radix peer dependency, which the title does not mention, but those are supporting changes and not the main point.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: eedbf2ef-0cc4-4e94-85bb-fdedc4883058
Commits
Reviewing files that changed from the base of the PR and between c6b0e73 and d720676.
Files selected for processing: 1
packages/plugin-sdk/src/ui.ts
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugins that manage log streams now use
LogViewerPanel, the same presentation component used by Kite's native Pod viewer. The existingLogViewerremains responsible for Pod subscriptions and requires a namespace.LogViewerPanelPropsandLogViewerEntrywith stable IDs, ANSI text, and optional Unix millisecond timestamps. The host formats timestamps in the browser's local timezone.follow,onStreamError, andonStreamEndtoLogsWebSocketOptions.This replaces the unreleased dual-mode LogViewer contract. Host implementation: kite-org/kite#792. The aggregated-logs plugin and generated packages are excluded and remain local; package versions are unchanged.
Validation passed:
pnpm run type-check(SDK and all existing plugins),pnpm run lint, andpnpm run format:check. The local aggregated-logs plugin also builds and packages with the new declarations.Summary by CodeRabbit