You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(sdk): expose pod file browser and delete confirmation - #4
Expose PodFileBrowser and DeleteConfirmationDialog from @kite-dev/plugin-sdk/ui so plugins can reuse Kite's native file browser and resource deletion confirmation.
The file browser props support a fixed container, a root directory for navigation, and read-only presentation. This PR contains only the component declarations and prop types; SDK package versions remain at 0.16.1.
Validation:
pnpm --filter @kite-dev/plugin-sdk build
pnpm run lint
pnpm run format:check
Summary by CodeRabbit
New Features
Added public UI components for browsing files in pods and confirming resource deletions.
Adds prop interfaces and component declarations for PodFileBrowser and DeleteConfirmationDialog. The props define component inputs and callbacks, including optional container settings and deletion options.
This change exposes type declarations for the pod file browser and delete confirmation dialog to plugins. No concrete defect was found in the declarations. One thing to confirm before relying on them is that the supported host version exports both components.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "feat(sdk): expose pod file browser and delete confirmation" matches the main change. The ui.ts file adds public prop interfaces and component declarations for PodFileBrowser and DeleteConfi…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "feat(sdk): expose pod file browser and delete confirmation" matches the main change. The ui.ts file adds public prop interfaces and component declarations for PodFileBrowser and DeleteConfirmationDialog, and the PR objectives state these are exported from @kite-dev/plugin-sdk/ui. The title is specific and uses a conventional commit format.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 4d2f7810-95dc-4d28-a4e6-fc1a21099ec4
Commits
Reviewing files that changed from the base of the PR and between 33b1dc4 and fe6cac7.
Files selected for processing: 1
packages/plugin-sdk/src/ui.ts
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose
PodFileBrowserandDeleteConfirmationDialogfrom@kite-dev/plugin-sdk/uiso plugins can reuse Kite's native file browser and resource deletion confirmation.The file browser props support a fixed container, a root directory for navigation, and read-only presentation. This PR contains only the component declarations and prop types; SDK package versions remain at 0.16.1.
Validation:
pnpm --filter @kite-dev/plugin-sdk buildpnpm run lintpnpm run format:checkSummary by CodeRabbit