Skip to content

I think the function 'hit' doesn't work as expect in some cases  #15

Description

@windschaser
  1. The doc says anySprite.circular = true; will make the sprite be interpreted as circular. In fact it doesn't work. I notice there's a block in the source code:
if (aIsASprite && bIsASprite) {
          //Yes, but what kind of sprites?
          if (a.diameter && b.diameter) {
            //They're circles
            return circleVsCircle(a, b);
          } else if (a.diameter && !b.diameter) {
            //The first one is a circle and the second is a rectangle
            return circleVsRectangle(a, b);
          } else {
            //They're rectangles
            return rectangleVsRectangle(a, b);
          }
        }

It seems that the function hit uses diameter as the flag of circle rather than circular. After my testing ,anySprite.diameter= true; works well.

  1. It seems that function movingCircleCollision works well----I mean both the circles move when they hit each other. But rectangleCollision and circleRectangleCollision won't move the second sprite passed into function. Is that a bug?
    P.S. I have passed the correct parameters, the call seems like this: b.hit(circle, rect, true, true);

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions