Conversation
- Upgrade swc_core from 65.0.1 to 77.1.2 (plugin ABI 27.0.0 -> 34.0.0) - Rebuild wasm plugin for wasm32-wasip1 - Bump @swc/core in example to 1.16.2 to match the new plugin ABI - Bump package version to 0.3.0
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@kmijs/swc-plugin-auto-css-modulesis a wasm plugin, and its ABI is tied to theswc_coreversion of the host (Rspack'sbuiltin:swc-loader). The 0.2.0 release was built againstswc_core65.0.1 (plugin ABI 27.0.0), which only works with Rspack 2.0.1 – 2.0.5. Since kmi declares@rspack/core: ^2.0.0, installs resolve to the latest 2.x (2.2.3,swc_core77.1.2 / plugin ABI 34.0.0), and builds fail with:See kmijs/kmi#53 for the full analysis. Consumed by kmijs/kmi#54.
This PR rebuilds the plugin against
swc_core77.1.2, so it works with Rspack 2.2.x (all 2.2.x releases use plugin ABI 34.0.0).Changes
swc_core(plugin + transform)@swc/core(example)swc_plugin_auto_css_modules.wasmwithwasm32-wasip1example's@swc/coreto 1.16.2 — the plugin ABI must match the host@swc/coreas well, and 1.14.0 can no longer load the pluginswc_core65 → 77 APIs used bysrc/lib.rsandtransform/are compatibleTest
Also verified end-to-end against
@rspack/core@2.2.3in a kmi workspace (plugin wired in via pnpm overrides):e2e/maxbuildpnpm test:e2e(e2e/max)pnpm test:e2e(e2e/with-qiankun-slave)