Skip to content

fix(index): honor project configuration in every entry point - #76

Merged
knight22-21 merged 3 commits into
knight22-21:mainfrom
sundaysebasidian-byte:fix/index-project-config-48
Oct 18, 2026
Merged

knight22-21 merged 3 commits into
knight22-21:mainfrom
sundaysebasidian-byte:fix/index-project-config-48

Conversation

@sundaysebasidian-byte

@sundaysebasidian-byte sundaysebasidian-byte commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Closes #48.

CLI index and MCP index_project now load .codeprism.toml before applying explicitly supplied language and embedding arguments. Omitted arguments inherit the file; --embeddings / -e, --no-embeddings, and MCP embeddings=false provide explicit overrides. Automatic parser workers and CLI --workers are preserved.

Merged main d8d9152e3a63d1bea342af32ddd37ee06be08bac into the existing branch without rewriting history. The changelog retains both the configuration fix and #75's symbol-search entry; upstream search ranking, pagination, query-error and statistics behavior and tests are preserved. The PR still changes the original five files. No repository dependencies or workflows changed.

Validation

Cloud Linux/Python 3.12.14, using an isolated environment installed from the existing .[dev] dependencies and temporary XDG data/config directories:

  • Configuration, search-pagination, CLI query/stats and MCP tests: 122 passed.
  • Full suite: 841 passed, 1 existing skip; 90.07% coverage (80% required).
  • Repository-wide Ruff lint/format checks and git diff --check passed.
  • Advisory mypy: the same 335 existing errors as main, with no additions after mapping unchanged source lines.
  • A separate Codex agent independently reviewed preservation of both parents and reran configuration/search tests: 67 passed, no blocking findings.

Current head: dcd26ea2eb0bc9d8356ff4cf3c9b5b8ee70d46d4. Its tree 5c7f8deabb8d6f48e4de915494c3d443049b9ccd matches the tested and independently reviewed tree. New-head CI and token benchmark passed for this head: Ubuntu/Python 3.12 and 3.13 full test/coverage jobs, Ruff, and the token benchmark. The CI merge tree also matches the tested tree.

Checklist

  • Tests cover changed behavior with real temporary projects and SQLite.
  • Ruff lint and formatting pass.
  • No new mypy errors.
  • Existing tests pass.
  • Public docstrings, README and changelog updated.
  • Conventional commits.

AI assistance: implementation, synchronization, validation and this description were prepared with Codex; a separate Codex agent performed the independent review. Optional embedding models were not downloaded or run.

@knight22-21

Copy link
Copy Markdown
Owner

Thanks for working on this! Please note that this pull request is currently marked as draft, so it cannot be reviewed or merged until it is marked as ready for review. Please convert it to ready for review when you are ready for maintainer review.

@sundaysebasidian-byte
sundaysebasidian-byte marked this pull request as ready for review October 10, 2026 15:13
@knight22-21

Copy link
Copy Markdown
Owner

Thanks @sundaysebasidian-byte! We have merged PR #75 into \main, which introduced a merge conflict (primarily in \docs/changelog.md). Could you please update your branch / rebase onto the latest \main\ to resolve the conflict? Once updated and CI checks pass, we will be ready to review and merge this.

@knight22-21 knight22-21 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thorough implementation ensuring project configuration is consistently honored across CLI and MCP entry points, with great test coverage.

@knight22-21
knight22-21 merged commit 912a2fb into knight22-21:main Oct 18, 2026
4 checks passed
@knight22-21

Copy link
Copy Markdown
Owner

Merged, thank you @sundaysebasidian-byte! This ensures project configuration from .codeprism.toml\ is consistently applied across CLI and MCP indexers.

@knight22-21 knight22-21 mentioned this pull request Oct 18, 2026
6 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.codeprism.toml is honoured only by the server's startup index; CLI index and index_project ignore it

2 participants