Repository navigation
Conversation
Signed-off-by: Damien L-G <dalg24@gmail.com>
Signed-off-by: Damien L-G <dalg24@gmail.com>
Signed-off-by: Damien L-G <dalg24@gmail.com>
dalg24
commented
Sep 28, 2026
| cmake_minimum_required(VERSION 3.22) | ||
|
|
||
| project(MDSpan | ||
| project(mdspan |
Member
Author
There was a problem hiding this comment.
IMO this should match the name of the package when we export the configuration.
Member
There was a problem hiding this comment.
It is recommended and it is a requirement for CPS. https://www.kitware.com/psa-your-package-name-and-target-namespace-should-match/
Member
There was a problem hiding this comment.
The requirement is really about the namespace and the project name. We can close #466 when merging then.
Signed-off-by: Damien L-G <dalg24@gmail.com>
crtrott
approved these changes
Sep 28, 2026
Member
Author
|
Hold on before you merge |
dalg24
marked this pull request as draft
September 28, 2026 16:59
Signed-off-by: Damien L-G <dalg24@gmail.com>
dalg24
force-pushed
the
configure_against_binary_dir
branch
from
September 28, 2026 19:05
0b3f6ef to
7614704
Compare
dalg24
marked this pull request as ready for review
September 28, 2026 19:41
Member
Author
|
Please wait on @nmm0 review before you merge |
This was referenced Sep 29, 2026
Member
Author
|
Not required now that we went with kokkos/kokkos#9604 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to kokkos/kokkos#9596
Enable to configure against
<builddir>/cmake_packages, and not<builddir>.This is a developer convenience, required in Kokkos Core. The recommended practice for users remains to configure against an install of Kokkos.
Blocks kokkos/kokkos#9517