Clang format

[lucbv]

No description provided.

[dalg24]

It looks like we (I) messed up in #468 and that the pre-commit check is not running

mdspan/.github/workflows/pre-commit.yml

Lines 3 to 4 in 8989f70

	on:
	workflow_call:

Please change it to on: [push, pull_request]

[lucbv]

Yes, I am actually inspecting why that is... the good news is that you are doing the some in kokkos/kokkos so there surely is a reason?
https://github.com/kokkos/kokkos/blob/develop/.github/workflows/pre-commit.yml

[masterleinad]

This is essentially the same as #414.

[dalg24]

https://github.com/kokkos/kokkos/blob/e8434a070a003dda91a1dcc0d40101deba7bd164/.github/workflows/continuous-integration-stager.yml#L15-L19

[lucbv]

@masterleinad that's a good point, although since pre-commit is being used for the license already maybe that makes this approach more appealing?
Also is there a will to apply all code changes in one large commit or should it be done incrementally when people touch various files of the library in PRs?

@dalg24 thanks for pointing out how this gets handled in kokkos, it makes sense there but probably not as much here so I will modify the workflow

[masterleinad]

Yes, I am actually inspecting why that is... the good news is that you are doing the some in kokkos/kokkos so there surely is a reason?

We are actually using workflow dispatch in Kokkos Core.

[masterleinad]

@masterleinad that's a good point, although since pre-commit is being used for the license already maybe that makes this approach more appealing?

I just wanted to make sure you have seen that one including its reviews and avoid duplicating efforts.

[lucbv]

I just wanted to make sure you have seen that one including its reviews and avoid duplicating efforts.

Thanks for pointing it out, I was not aware when I made this PR. At least this revealed the lack of running check for license detection. Also I mostly did it so I can test this before doing it in Kokkos Kernels, so I'm really using mdspan as a guinea-pig 🫢

[masterleinad]

Not sure if this should be in a separate pull request.

[lucbv]

Agreed, here is my rational:

• it is required for the clang-format check to work
• the license check passes so it did not generate additional changes unrelated to formatting

If we needed changes because of the license check I would lean for two PRs but here I can get away with one in my opinion

[masterleinad]

I just added another pull request just for this change, #475.

[dalg24]

@crtrott @nmm0 please advise on what format you would like to use.