Skip to content

replace strided_slice with extent_slice - #476

Merged
crtrott merged 3 commits into
kokkos:stablefrom
nmm0:add-extent-slice
Oct 1, 2026
Merged

crtrott merged 3 commits into
kokkos:stablefrom
nmm0:add-extent-slice

Conversation

@nmm0

@nmm0 nmm0 commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

This replaces strided_slice with extent_slice as strided_slice was renamed in the C++26 standard. This currently does not also add range_slice which will be done in another PR.

Currently this deprecates use of strided_slice but I am open to discussing that.

@crtrott

crtrott commented Sep 30, 2026

Copy link
Copy Markdown
Member

Hm, I don't think this is right. extent_slice also changed the meaning of "extent" didn't it?

@nmm0

nmm0 commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor Author

Hm, I don't think this is right. extent_slice also changed the meaning of "extent" didn't it?

I might be mixing up things but at least in https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2026/p3982r2.html it specifies extent_slice is just a rename of strided_slice, and indeed the wording in that paper only has the range_slice change.

Ah nvm I misread the wording it had an additional change to extents

@crtrott crtrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a test somewhere which is actually sensitive to the change you just did.

@nmm0

nmm0 commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

We should have a test somewhere which is actually sensitive to the change you just did.

The current test should check it, as in I had to adjust the test after the change to just use the extent or it would not pass. Unless you had something specific in mind?

@crtrott

crtrott commented Oct 1, 2026

Copy link
Copy Markdown
Member

Ah ok found it.

@crtrott

crtrott commented Oct 1, 2026

Copy link
Copy Markdown
Member

I tested a Serial build in Kokkos and it passed.

@crtrott
crtrott merged commit ed9f513 into kokkos:stable Oct 1, 2026
16 checks passed
@dalg24

dalg24 commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

You tested against Kokkos, right?
Nevermind I see #476 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants