Repository navigation
replace strided_slice with extent_slice - #476
Conversation
|
Hm, I don't think this is right. extent_slice also changed the meaning of "extent" didn't it? |
Ah nvm I misread the wording it had an additional change to extents |
…g elements instead of the range of elements
crtrott
left a comment
There was a problem hiding this comment.
We should have a test somewhere which is actually sensitive to the change you just did.
The current test should check it, as in I had to adjust the test after the change to just use the extent or it would not pass. Unless you had something specific in mind? |
|
Ah ok found it. |
|
I tested a Serial build in Kokkos and it passed. |
|
|
This replaces
strided_slicewithextent_sliceasstrided_slicewas renamed in the C++26 standard. This currently does not also addrange_slicewhich will be done in another PR.Currently this deprecates use of
strided_slicebut I am open to discussing that.