chore: drop the depthai-core submodule; depthai-rs owns the build - #16
Merged
Merged
Conversation
…wns the build kornia/depthai-rs now carries the pinned depthai-core source, the tag, the build script and a `vendored` feature that builds it from cargo. Keeping a second v3.7.1 pin here meant two things to bump in lockstep for one library. - vendor/depthai-core submodule, .gitmodules, scripts/build_depthai.sh and the pixi depthai-build/pack/unpack tasks (and the stale oakd_track3d tasks) go. - sensor-oak gains `vendored = ["depthai-sys/vendored"]` so a machine without a prefix can `cargo build -p sensor-oak --features vendored`. - CI's jetson job takes DEPTHAI_PREFIX instead of checking out submodules and setting LD_LIBRARY_PATH (depthai-sys bakes the rpath). - README / CLAUDE.md / .gitignore describe the prefix-or-vendored flow. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TmCRdrYoyj2zokHSv5EvvM
…ource submodule Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TmCRdrYoyj2zokHSv5EvvM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kornia/depthai-rs now carries the pinned depthai-core source, the tag, the build script and a
vendoredfeature. Keeping a secondv3.7.1pin here meant two things to bump in lockstep for one library, so this repo stops vendoring it:vendor/depthai-coresubmodule,.gitmodules,scripts/build_depthai.sh, the pixidepthai-build/pack/unpacktasks (and the staleoakd_track3dtasks) are removed.sensor-oakgainsvendored = ["depthai-sys/vendored"]: a machine without a prefix runscargo build -p sensor-oak --features vendored(cmake/ninja/pkg-config frompixi shell).DEPTHAI_PREFIXinstead ofsubmodules: recursive+LD_LIBRARY_PATH(depthai-sys bakes the rpath).No code change in the crates.
Test plan
cargo metadata --locked,cargo fmt --checkDEPTHAI_PREFIXpointing at the depthai-rs-built prefix:cargo build -p sensor-oakcargo build -p sensor-oak --features vendoredon a machine with cmake/ninja (needs ~4 GB free)🤖 Generated with Claude Code
https://claude.ai/code/session_01TmCRdrYoyj2zokHSv5EvvM