Repository navigation
feat: suggest and highlight @claude mentions, and quote a comment to ask claude - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mentioning Claude in a comment now works like mentioning a person in a doc, matching the hosted Artifacts comments:
@(or@cl) in a new comment or a reply opens a People menu with Claude at the caret. Enter, Tab or a click inserts@Claude. Esc closes only the menu, and Enter picks the suggestion instead of sending.@Claudeshows as a chip while typing and in posted comments. It uses the daemon's own rule (a whole word after a space or the line start), sofoo@claudeand@claudettestay plain. Text a page wrote is never chipped, because it doesn't reach Claude.@Claudegoes to Claude whichever control is used, as the daemon already did. The reply button now says "Reply & send to Claude", and the new-comment box hides its plain Comment button, so the UI matches what happens.@Claudeand keeps anything already typed. Leading>lines render as a quote block.The editor highlight is drawn by a mirror behind a transparent textarea, so the caret, selection, IME input and image drops are unchanged. There are no server changes.
Smoke test
@. A menu listing Claude appears at the caret. Press Enter:@Claudeis inserted as a blue chip and nothing is sent.@cl, then press Tab. The button still reads "Reply & send to Claude". Post it: the thread is sent to Claude.foo@claude @claudette. Neither is highlighted.> <that comment>and@Claude, with the caret at the end. Type and post: the reply shows the quote block and the chip.