Repository navigation
Write the root README's progression example in chart syntax [patch] - #474
Merged
Merged
Conversation
Progression.Parse("| Dm7 | G7 | Cmaj7 |") throws, because a chart now
opens with its time signature. The snippet uses the chart form instead,
and a test checks every Progression.Parse literal in the root and Music
READMEs, and the root example's commented key and numerals.
Fixes #374
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CcmGrWCwm3uDHcCpVZVcJU
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #374
What was wrong
The root README's "Semantic music" snippet opened with
Progression.Parse("| Dm7 | G7 | Cmaj7 |"). That is the bar-delimited form #113 replaced: a chart now has to start with its time signature, so the first music example on the package's front page threwFormatException.Change
README.mdnow usesProgression.Parse("4/4 Dm7 / / / | G7 / / / | Cmaj7 / / /"). The comments on the following lines still hold: the key is C major, and the numerals areii7, V7, Imaj7.Parse("|outsidedocs/superpowers, which holds historical plans.Tests
Semantics.Testnow copies the root and Music READMEs into its output underReadmes/, the same way it already copies the generator metadata. The newReadmeExampleTestsadds two tests:EveryProgressionLiteralInTheReadmesParsesruns everyProgression.Parse("…")literal in both READMEs throughTryParse.RootReadmeMusicExample_GivesTheOutputsItsCommentsShowchecks the root example's commented key (C major) and numerals.Results:
This branch stands alone on
main, and it merges cleanly with #472 and #473.Generated by Claude Code