Skip to content

aws: Generate NodePool requirements for instanceRequirements - #18676

Open
danports wants to merge 1 commit into
kubernetes:masterfrom
danports:karpenter-instance-requirements
Open

aws: Generate NodePool requirements for instanceRequirements#18676
danports wants to merge 1 commit into
kubernetes:masterfrom
danports:karpenter-instance-requirements

Conversation

@danports

@danports danports commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Updates the Karpenter addon to support mixedInstancesPolicy.instanceRequirements specified in instance groups because, really, who wants to maintain a massive list of instance types in mixedInstancesPolicy.instances? 🙃

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 8, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @danports. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 8, 2026
@kubernetes-prow
kubernetes-prow Bot requested review from olemarkus and zetaab August 8, 2026 15:59
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hakman for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added area/documentation needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 8, 2026
@danports
danports force-pushed the karpenter-instance-requirements branch from ce4a95b to c40f9ff Compare August 18, 2026 19:56
@kubernetes-prow kubernetes-prow Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 18, 2026
@danports
danports force-pushed the karpenter-instance-requirements branch from c40f9ff to 162414e Compare August 27, 2026 02:19
@kubernetes-prow kubernetes-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant