Repository navigation
feat: report RSS refresh failures from the settled feed state - #28
Merged
Merged
Conversation
kxxoling
force-pushed
the
feat/rss-refresh-errors
branch
4 times, most recently
from
October 20, 2026 01:48
5d9bc50 to
3199105
Compare
qBT's refreshItem is fire-and-forget, so the old flow could toast success
from a snapshot that predated the server applying the refresh. Now a feed
only counts as settled once it was observed loading (or after a grace
period), and vanished feeds / rejected POSTs count as failures too.
Feedback is immediate: every refresh starts a spinner toast (sonner's
toast.loading) that swaps in place for the outcome once the poll loop
settles — single refresh resolves it to Refreshed / Refresh failed, and
refresh-all resolves it to Refreshed or dismisses it in favor of one
error toast per failed feed ("{name} failed to refresh"), since hasError
carries no reason. The feed tree also marks hasError rows persistently,
like the official UI.
kxxoling
force-pushed
the
feat/rss-refresh-errors
branch
from
October 20, 2026 01:59
3199105 to
3122b95
Compare
kxxoling
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qBT's
refreshItemis fire-and-forget — the old flow could toast successfrom a snapshot that predated the server applying the refresh.
grace period); vanished feeds and rejected POSTs count as failures too.
toast.loading) thatswaps in place for the outcome once polling settles.
hasErrorcarries no reason, so failures are plain: single refresh →"Refresh failed"; refresh-all → one
"{name} failed to refresh"toastper failed feed.
hasErrorrows persistently, like the official UI.