Skip to content

fix: missing newline in ndjson exporter after baseline - #311

Open
kxxt wants to merge 1 commit into
mainfrom
exporter-ndjson-fix
Open

fix: missing newline in ndjson exporter after baseline#311
kxxt wants to merge 1 commit into
mainfrom
exporter-ndjson-fix

Conversation

@kxxt

@kxxt kxxt commented Aug 25, 2026

Copy link
Copy Markdown
Owner

No description provided.

@vercel

vercel Bot commented Aug 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tracexec Ready Ready Preview Aug 25, 2026 3:23pm

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 36 minutes.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro Plus

Run ID: b49635a2-2d98-4a19-ad3f-4ca84f9e54c0

📥 Commits

Reviewing files that changed from the base of the PR and between c2a06bd and 93b43b5.

📒 Files selected for processing (1)
  • crates/tracexec-exporter-json/src/lib.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Aug 25, 2026

Copy link
Copy Markdown

Greptile Summary

The PR fixes JSON stream framing by terminating the initial baseline metadata record with a newline and immediately flushing it before awaiting trace events.

  • Adds the missing record separator after baseline serialization.
  • Flushes the output so streaming consumers can read the baseline without waiting for a later event.

Confidence Score: 5/5

The PR appears safe to merge, with the focused change restoring the documented newline-delimited streaming contract.

The added newline separates baseline metadata from subsequent event records, and the flush makes that first complete record promptly available to streaming consumers.

Important Files Changed

Filename Overview
crates/tracexec-exporter-json/src/lib.rs Correctly completes and flushes the baseline NDJSON record before processing streamed events; no actionable issues identified.

Reviews (1): Last reviewed commit: "fix: missing newline in ndjson exporter ..." | Re-trigger Greptile

@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.43%. Comparing base (73679bb) to head (93b43b5).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #311   +/-   ##
=======================================
  Coverage   82.43%   82.43%           
=======================================
  Files          84       84           
  Lines       21274    21276    +2     
=======================================
+ Hits        17537    17539    +2     
  Misses       3737     3737           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant