feat(Where): improve estimated time and planning - #252
Merged
Conversation
kyleve
force-pushed
the
codex/improve-estimated-time-planning
branch
from
August 13, 2026 00:50
dd40b29 to
b8e2be4
Compare
…imated-time-planning
kyleve
force-pushed
the
codex/improve-estimated-time-planning
branch
from
August 13, 2026 18:24
2efa04c to
1a4c015
Compare
…ed-time-planning # Conflicts: # Where/WhereUI/SnapshotTests/__Snapshots__/CalendarContentViewSnapshotTests/calendarContent.WithData_iPad_accessibility.png # Where/WhereUI/SnapshotTests/__Snapshots__/CalendarContentViewSnapshotTests/calendarContent.WithData_iPhone_accessibility.png # Where/WhereUI/SnapshotTests/__Snapshots__/YearViewSnapshotTests/year.Loaded_iPad_accessibility.png # Where/WhereUI/SnapshotTests/__Snapshots__/YearViewSnapshotTests/year.Loaded_iPhone_accessibility.png # Where/WhereUI/Sources/Shared/WhereFormat.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Planned stays previously affected only the selected region's total, so reserving time in California did not reduce New York's projection. Planning was also available only from Calendar, the forecast math lacked an in-depth educational surface, and the existing visibility preference did not consistently hide every planning visualization. Calendar's generic bottom anchor also opened below the useful current-month context.
Review focus
where.showsLocationForecastsOnLocationsTabso existing choices survive the broader semantics.ScrollPositiontargeting the current month rather than a global bottom anchor; the fixed-viewport snapshot pins the resulting estimate-card peek.Compatibility
No persisted schema or backup format changes. The device-local preference keeps its existing raw defaults key, and planned-stay clearing continues through the existing synced tombstone path.
Testing
./swiftformat --lint./xcstrings --lint./sf-symbols --lint./test --all— 1,863 tests passed./test --snapshots— 43 snapshot suites passedLocationsViewSnapshotTestsmatrix passedStack