Skip to content

fix(Where): disable Sentry crash reporting - #255

Merged
kyleve merged 1 commit into
mainfrom
codex/disable-sentry
Aug 13, 2026
Merged

fix(Where): disable Sentry crash reporting#255
kyleve merged 1 commit into
mainfrom
codex/disable-sentry

Conversation

@kyleve

@kyleve kyleve commented Aug 13, 2026

Copy link
Copy Markdown
Owner

Posted by an AI agent on kyleve’s behalf.

Summary

  • Remove Sentry from the Where app composition root and Swift package graph.
  • Keep Bitdrift as the sole crash reporter so its crash ingestion can be evaluated independently.
  • Remove the Sentry adapter, tests, attribution, and stale documentation.

Why

PR #224 introduced Sentry and Bitdrift together. The follow-up binary/build analysis found that Sentry materializes roughly 2.83 GiB of build artifacts in fresh DerivedData, making it the clearest contributor to the disk and clean-build regression. Removing the dependency entirely also prevents Sentry from intercepting crashes while Bitdrift is being evaluated.

Analysis: #224 (comment)

Review focus

  • Bitdrift launch wiring and its test-process guard are unchanged.
  • The vendor-neutral launch-order test still proves every configured reporter starts before the selected runtime.
  • This removes Sentry from package resolution and linking, rather than merely suppressing SDK startup, so its artifacts are no longer built.

Testing

  • ./ide --no-open
  • ./swiftformat --lint
  • ./attribution --check
  • ./test --no-generate --no-build WhereCrashReportingTests — 3 passed
  • ./test --no-generate --no-build WhereTests — 15 passed
  • ./test — backup-upgrader checks and all 42 snapshot tests passed; the aggregate unit invocation could not start because the affected-target selector included macOS-only LedgerCoreTests in the iOS Stuff-iOS-Tests scheme

@kyleve
kyleve enabled auto-merge (squash) August 13, 2026 03:07
@kyleve
kyleve merged commit 36806ee into main Aug 13, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant