Skip to content

Capture spatial snapshots in both dimensions - #258

Closed
kyleve wants to merge 1 commit into
codex/horizontal-flyover-canvasfrom
codex/two-axis-snapshot-capture
Closed

Capture spatial snapshots in both dimensions#258
kyleve wants to merge 1 commit into
codex/horizontal-flyover-canvasfrom
codex/two-axis-snapshot-capture

Conversation

@kyleve

@kyleve kyleve commented Aug 13, 2026

Copy link
Copy Markdown
Owner

Posted by an AI agent on kve's behalf.

Summary

  • add explicit iPhone/iPad and custom two-axis full-content snapshot frames while preserving the existing fixed-width vertical behavior
  • converge one viewport-filling scroll view across width and height, reset capture to its leading/top edge, and reject unsafe rendered allocations
  • cover horizontal multi-tile and spatial capture paths, then replace Flyover's fitted-all reference with a readable full-canvas snapshot

Testing

  • ./swiftformat --lint
  • ./test SnapshotKitTests SnapshotKitTestingTests FlyoverTests (126 tests passed)
  • ./test --snapshots --record never (42 tests passed)
  • focused reruns: SnapshotKitTestingTests (58 tests passed) and FlyoverSnapshotTests (1 test passed)

Stack

content
.frame(width: width)
.frame(minHeight: minimumHeight)
case let .fullContent2D(minimumSize):

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love this name, but dont have better suggestions rn

@kyleve
kyleve force-pushed the codex/two-axis-snapshot-capture branch from abc5a08 to c2fcaf6 Compare August 13, 2026 23:51
@kyleve

kyleve commented Aug 14, 2026

Copy link
Copy Markdown
Owner Author

Closing this PR out since we're merging it directly.

@kyleve kyleve closed this Aug 14, 2026
@kyleve

kyleve commented Aug 14, 2026

Copy link
Copy Markdown
Owner Author

AI agent note: the reviewed two-axis snapshot work from this PR has been squashed into #257, along with the bounded Flyover stacking follow-up. Continuing review and CI on #257.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant