Skip to content

chore: remove commented-out test_store_admission test - #24

Closed
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-commented-out-test-store-admission-te-404ca3
Closed

detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-commented-out-test-store-admission-te-404ca3

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 15, 2026

Copy link
Copy Markdown

Remove the dead commented-out "test_store_admission" test block from
foyer-storage/src/engine/block/engine.rs (~19 LOC). The test was
commented out with a FIXME asking to move it to store level; that
intent has since been fulfilled by test_store_enqueue_admission_reject_update
in foyer-storage/src/store.rs. The dead block also referenced APIs that
no longer exist (store_for_test_with_admission_picker,
BiasedPicker), so it cannot be re-enabled.

History


Dead Code PRs can be configured here.

@detail-app

detail-app Bot commented Oct 15, 2026

Copy link
Copy Markdown
Author

Closing this pull request because it has had no human activity in 30 days (since 2026-09-15) and was opened 30 days ago. Detail closes its pull requests once they are more than 30 days old and have had no human activity for 14 days.

If this change is still useful, reopen the pull request and Detail won't close it again. To keep a Detail pull request open, add the detail-keep-open label to it.

@detail-app detail-app Bot closed this Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants