Repository navigation
chore(storage): remove unused Raw::into_raw_parts/from_raw_parts - #25
Closed
detail-app[bot] wants to merge 1 commit into
Closed
detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
Author
|
Closing this pull request because it has had no human activity in 30 days (since 2026-09-15) and was opened 30 days ago. Detail closes its pull requests once they are more than 30 days old and have had no human activity for 14 days. If this change is still useful, reopen the pull request and Detail won't close it again. To keep a Detail pull request open, add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
Raw::into_raw_partsandRaw::from_raw_partsfromfoyer-storage/src/io/bytes.rs. Both methods have zero callers anywherein the codebase (production or test).
The methods were originally introduced on the old
IoBuffertype andhad callers, but those callers were dropped when the io engine
abstraction was introduced (PR foyer-rs#1063). The methods were carried forward
as a rename + relocation (
IoBuffer->Raw) but never wired up tonew consumers, leaving them as dead code. The field management they
existed to support is now handled independently by the
Drop,Deref,DerefMut,Clone, andIoB::as_raw_partsimpls onRaw.History
Dead Code PRs can be configured here.