Repository navigation
chore: remove unused simulated io latency config from UringIoEngineConfig - #26
Closed
detail-app[bot] wants to merge 1 commit into
Closed
detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
Author
|
Closing this pull request because it has had no human activity in 30 days (since 2026-09-15) and was opened 30 days ago. Detail closes its pull requests once they are more than 30 days old and have had no human activity for 14 days. If this change is still useful, reopen the pull request and Detail won't close it again. To keep a Detail pull request open, add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the write_io_latency and read_io_latency fields, their None initializers in new(), and the with_write_io_latency/with_read_io_latency setter methods from UringIoEngineConfig.
These symbols were dead: the setters were never called on UringIoEngineConfig anywhere in the workspace (foyer-bench only calls them on PsyncIoEngineConfig), and the fields were written but never read by the uring engine's build/run/read/write paths. They were added for API parity with psync but never wired into the uring engine, and the foyer-bench CLI documents the feature as "Only effective when using psync io engine".
History
Dead Code PRs can be configured here.