Skip to content

chore: remove unused bits utilities is_pow2, assert_pow2, debug_assert_aligned - #27

Closed
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-bits-utilities-is-pow2-assert-4c82b3
Closed

detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-bits-utilities-is-pow2-assert-4c82b3

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 22, 2026

Copy link
Copy Markdown

Removes three unused public functions from foyer-common/src/bits.rs:

  • is_pow2: never had any callers in the workspace.
  • assert_pow2: never had any callers in the workspace.
  • debug_assert_aligned: last callers were in the large disk cache flusher
    and were removed during the parallel buffer writing refactor.

The remaining bits module functions (debug_assert_pow2, is_aligned,
assert_aligned, align_up, align_down) remain in use by foyer-storage.

History


Dead Code PRs can be configured here.

@detail-app

detail-app Bot commented Oct 22, 2026

Copy link
Copy Markdown
Author

Closing this pull request because it has had no human activity in 30 days (since 2026-09-22) and was opened 30 days ago. Detail closes its pull requests once they are more than 30 days old and have had no human activity for 14 days.

If this change is still useful, reopen the pull request and Detail won't close it again. To keep a Detail pull request open, add the detail-keep-open label to it.

@detail-app detail-app Bot closed this Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants