Skip to content

fix: change litellm tests in order to change deprecated model - #2543

Merged
lucaseduoli merged 1 commit into
mainfrom
fix/litellm_tests
Oct 23, 2026
Merged

lucaseduoli merged 1 commit into
mainfrom
fix/litellm_tests

Conversation

@lucaseduoli

@lucaseduoli lucaseduoli commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

This pull request updates the test for vision model tagging in the test_model_catalog.py file to use a newer model name and adjust capability assertions accordingly.

Test updates for model capabilities:

  • Updated the test configuration and assertions to use gpt-5.5-cyber instead of gpt-3.5-turbo, checking for the vision and reasoning capabilities on the new model, and ensuring the preview variant does not have the vision capability.

Summary by CodeRabbit

  • Tests
    • Updated model catalog coverage to verify that the configured vision model retains its reasoning capability.

@lucaseduoli
lucaseduoli requested a review from mpawlow October 23, 2026 19:00
@lucaseduoli lucaseduoli self-assigned this Oct 23, 2026
@github-actions github-actions Bot added tests bug 🔴 Something isn't working. labels Oct 23, 2026
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between e4c4f01 and 21d61c0.

📒 Files selected for processing: 1
  • tests/unit/services/test_model_catalog.py

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.

Walkthrough

The configured-vision test now uses gpt-5.5-cyber and checks for vision and reasoning. The custom-model and preview-model assertions remain unchanged.

Changes

Model catalog test

Layer / File(s) Summary
Configured model assertions
tests/unit/services/test_model_catalog.py
The configured model changes from gpt-3.5-turbo to gpt-5.5-cyber. The test now expects vision and reasoning capabilities.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested labels: tests

Suggested reviewers: mfortman11

Merge Risk: ⚪ Minimal · up to 21d61

The test update introduces no actionable merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately describes the main change: updating LiteLLM tests to replace a deprecated model. The wording is awkward but remains clear and relevant.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added bug 🔴 Something isn't working. and removed bug 🔴 Something isn't working. labels Oct 23, 2026

@mpawlow mpawlow left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

  • ✅ Approved / LGTM 🚀

@github-actions github-actions Bot added the lgtm label Oct 23, 2026
@lucaseduoli
lucaseduoli merged commit bb8623b into main Oct 23, 2026
38 checks passed
@github-actions
github-actions Bot deleted the fix/litellm_tests branch October 23, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🔴 Something isn't working. lgtm tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants