Skip to content

Unbreak the website PR check - #115

Merged
xuelink merged 1 commit into
mainfrom
xuelink/fix-website-ci
Aug 28, 2026
Merged

Unbreak the website PR check#115
xuelink merged 1 commit into
mainfrom
xuelink/fix-website-ci

Conversation

@xuelink

@xuelink xuelink commented Aug 28, 2026

Copy link
Copy Markdown
Member

Every pull request has been failing in three seconds, before a step runs: "This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v3."

The source is upload-pages-artifact@v2, which calls v3 underneath. Rather than bump it, the step is gone. It uploaded a GitHub Pages artifact that nothing consumes: the site deploys from deploy.yml to Cloudflare Pages, and that workflow runs its own build and its own upload-artifact@v4. The step was left over from a Pages deploy that no longer exists, so upgrading it would have kept a dead artifact alive at the cost of a second maintenance point.

Two versions came up with it: setup-node@v1 (2019) and checkout@main, which tracked a branch — upstream changing meant our CI changing with no commit here.

Left alone deliberately: the BASE_PATH env, which deploy.yml also sets and which keeps the two builds identical, and the step list itself — adding lint or tests here is a separate argument.

This blocks #114, which is otherwise green.

Every pull request has been failing in three seconds, before a step runs:

    This request has been automatically failed because it uses a deprecated
    version of `actions/upload-artifact: v3`.

The source is `upload-pages-artifact@v2`, which calls v3 underneath. Rather
than bump it, the step is gone. It uploaded a GitHub Pages artifact that
nothing consumes: the site deploys from `deploy.yml` to Cloudflare Pages, and
that workflow runs its own build and its own `upload-artifact@v4`. The step was
left over from a Pages deploy that no longer exists, so upgrading it would have
kept a dead artifact alive at the cost of a second maintenance point.

Two versions came up with it: `setup-node@v1` (2019) and `checkout@main`, which
tracked a branch — upstream changing meant our CI changing with no commit here.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@xuelink xuelink mentioned this pull request Aug 28, 2026
@xuelink
xuelink merged commit a956cd3 into main Aug 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant