Repository navigation
chore: adaptations preparing for Lean v4.37.0 - #194
Merged
Merged
Conversation
This PR replaces iterating over `env.const2ModIdx` with iterating over `env.header.moduleData`, since the upcoming Lean release drops `Environment.const2ModIdx`. I am making this PR since Mathlib's nightly-testing depends on ImportGraph's `main` branch. This was copied from downstream-lean4: leanprover/downstream-lean4@d3dcf6c#diff-049347008dd76be0699af5a73c59a08b773210018948e22fdc8bf5bdd0c34c0e I checked that the adapted code makes sense and the tests still pass. Lean PR: leanprover/lean4#14362
thorimur
reviewed
Nov 12, 2026
thorimur
left a comment
thorimur
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me modulo these tiny changes! :)
Collaborator
|
|
Contributor
Author
|
The changes should be upstream[ed,able] to downstream-lean4 either in their own PR or whenever they merge from here. |
Collaborator
|
I'm going to go ahead and merge this since it's a request for speedy review and quite small, so I'm hoping this helps out. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces iterating over
env.const2ModIdxwith iterating overenv.header.moduleData, since the upcoming Lean release dropsEnvironment.const2ModIdx. I am making this PR since Mathlib's nightly-testing depends on ImportGraph'smainbranch.This was initially copied from downstream-lean4: leanprover/downstream-lean4@d3dcf6c#diff-049347008dd76be0699af5a73c59a08b773210018948e22fdc8bf5bdd0c34c0e I checked that the adapted code makes sense and the tests still pass. It was then modified during review.
Lean PR: leanprover/lean4#14362