Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents early fine-grained traces from consuming the speculative profiling result before later hotspots and declaration phases are considered. It visits shallow trace nodes first, retains spans by inclusive duration together with their ancestors, and restores original tree order and parent indices. The retained cap is reduced to 128 spans; summary selection, labels, numeric precision, thread identities and the public schema are unchanged.
Traversal remains bounded by 16,384 visits and message depth 256. Omitted spans or exhausted traversal bounds continue to set
truncated.The frozen eight-case Mathlib qualification compares
6cae79f6withf8a33b9bon Lean 4.34.0-rc2, with one warmup and three measured rounds per case. A pass requires successful execution, the reference hotspot in the first three summary entries, expected phases, stable leading entries, and a compact UTF-8 profile object at most 20,000 bytes. Whole-response bytes are not scored because Lean warnings add unrelated text. This corpus is external to CI.Score: 5/8 → 5/8, with no previously passing case regressed. All candidate cases pass execution and stability, and all expected Kernel phases are retained. This draft does not yet meet the 8/8 acceptance target. Pure duration retention still omits a short maxSharing phase; the preserved grind hotspot ranks after three genuinely longer scopes; two profile objects still exceed the budget. Raw-span compaction is reserved for a separate follow-up and is not included here.