Repository navigation
Remove accidental Lake and Lean imports from generated challenges - #668
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated challenges explicitly imported
Lake.Toml,Lake.Util.Message, andLeanbecauseEvalTools.Markersexposed those implementation dependencies. This broke consumers that reuse challenges, including Comparator's finite graph Ramsey preset.Source modules still receive these implementation dependencies transitively through the marker implementation; the standalone generated headers now omit them.
Keep the compatibility marker module limited to
LeanEvalGenerator.Core.Markers, which the generator already omits, and regenerate all 312 workspaces. This removes the accidental imports from 499 files across 307 workspaces. Add regression checks for marker-only modules and the narrow Ramsey import header. Rename an implicitly used commuting-probability binder to clear an existing linter warning in its generated solution wrapper.Validation:
sorryholes; the commuting-probability wrapper also passes after the binder fix.git diff --checkpass.