Repository navigation
ci: reject Mathlib pins whose cache lacks modules - #672
Merged
Merged
Conversation
Evaluation restores dependencies with compilation disabled, so one module missing from Mathlib's cache (as with Mathlib b63f6e8, which lacked Mathlib.Tactic.CategoryTheory.BicategoryCoherence) fails every submission. For each benchmark configuration, clone only the pinned Mathlib, run `lake exe cache get` and require `lake --no-build build Mathlib` to succeed, and require its toolchain to match the configuration's. Run the workflow when the root lakefile or manifest changes too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
mathlib cachejob, one per benchmark configuration (rc and stable), to the dependency cache restoration workflow, and makes the requiredrestorecheck depend on it. The job clones only the configuration's pinned Mathlib, runslake exe cache get, and requireslake --no-build build Mathlibto succeed. It also requires Mathlib's toolchain to match the configuration's.Evaluation restores dependencies with compilation disabled, so a single module missing from Mathlib's cache fails every submission. Mathlib
b63f6e8lackedMathlib.Tactic.CategoryTheory.BicategoryCoherence, and evaluations failed from late October until #670 moved the pins. Cloning Mathlib alone keeps the job clear of the large solution libraries that materializing the benchmark workspace would fetch. The workflow now also runs when the rootlakefile.tomlorlake-manifest.jsonchanges.🤖 Prepared with Claude Code