Repository navigation
test: log git calls when Lake fails in the local-dep tests - #821
Merged
Merged
Conversation
On Windows, CI run 43085382097 failed in the `before all` hook of "Project action commands > with a local git dependency": Lake's `git fetch` of the local `dep` repository exited with an error and wrote no output, so Lake reported only "failed to fetch the package revision". The cause could not be found from the log. `lake()` now runs Lake with `GIT_TRACE2` set to a new folder. Each git process writes a trace2 log there: the command line, the child processes and their exit codes, the `die()` messages and the exit code. If Lake fails, the error contains these logs and the exit code of Lake (with the NTSTATUS in hex on Windows) instead of a second copy of stderr. A log without an `exit` line shows a git process that stopped, and a missing log shows a process that did not start. `withGitTrace(fn)` sets `GIT_TRACE2` in `process.env` for the time of `fn`, so that the git calls that the extension starts through Lake also write logs, and adds the logs to the error if `fn` fails. The two `updateDependency` tests use it, because they run the same fetch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.