Skip to content

fix: keep the infoview working after a file worker crashes - #825

Open
mhuisi wants to merge 1 commit into
leanprover:masterfrom
mhuisi:push-uoqkypvmntoq
Open

mhuisi wants to merge 1 commit into
leanprover:masterfrom
mhuisi:push-uoqkypvmntoq

Conversation

@mhuisi

@mhuisi mhuisi commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

This PR makes the infoview show the crash of a file worker as an error in the affected infos, and recover when the next edit restarts the worker. Before, one failed request put the infoview of the file into a stopped state that only Lean 4: Restart File or a restart of the server ended, also after the Lean server had started a new worker for the file.

The extension no longer tracks crashed file workers: the errors of the requests already report the crash, and the Lean server starts a new worker when the file changes. With this state, the notification that offered to restart the file is gone, and so is the unused file mode of LeanClient.showRestartMessage.

This PR makes the infoview show the crash of a file worker as an error in the affected infos, and recover when the next edit restarts the worker. Before, one failed request put the infoview of the file into a stopped state that only `Lean 4: Restart File` or a restart of the server ended, also after the Lean server had started a new worker for the file.

The extension no longer tracks crashed file workers: the errors of the requests already report the crash, and the Lean server starts a new worker when the file changes. With this state, the notification that offered to restart the file is gone, and so is the unused file mode of `LeanClient.showRestartMessage`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mhuisi
mhuisi requested a review from Vtec234 November 13, 2026 16:12

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants