Skip to content

Fixed + added test for bug in VoV unit conversion - #228

Merged
iguinn merged 1 commit into
legend-exp:mainfrom
iguinn:main
Oct 5, 2026
Merged

iguinn merged 1 commit into
legend-exp:mainfrom
iguinn:main

Conversation

@iguinn

@iguinn iguinn commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

Fixed bug where first write of VoV that is undergoing unit conversion comes out as all zeros. Now when a UnitConversionManager is created, it will execute.

@codecov

codecov Bot commented Oct 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.08%. Comparing base (ae7b4e1) to head (861334e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #228   +/-   ##
=======================================
  Coverage   69.07%   69.08%           
=======================================
  Files          62       62           
  Lines        4188     4189    +1     
=======================================
+ Hits         2893     2894    +1     
  Misses       1295     1295           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@iguinn
iguinn merged commit e757a39 into legend-exp:main Oct 5, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant