Repository navigation
test(conformance): a digit-initial non-number is an error - #26
Merged
lejmr merged 3 commits intoOct 22, 2026
Merged
Conversation
Proofreading the suite against spec/HOCON.md found two rules no case pinned, both places where zig-hocon and pyhocon part ways:
- unquoted-strings/025: a = 1.2.3 must be parsed as a number and is not one, so it is an error (java: lenient, it and pyhocon read the string "1.2.3")
- plus-equals-field-separator/009: a += [3, 4] is a = ${?a} [[3, 4]], so the list is appended as one element (typesafe/config agrees; pyhocon splices it)
a += [3, 4] is 001's desugaring with 008's composite element, and pyhocon already fails the whole += section, so the case told no implementation apart. Java, pyhocon and zig-hocon measured on the 446; MIGRATING.md says an IP address needs quotes, which is what 025 means for a pyhocon user. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CbBo1aotFTDLY2gery7qYD
lejmr
changed the title
lejmr
marked this pull request as ready for review
October 22, 2026 19:44
lejmr
deleted the
conformance/digit-initial-number-and-plus-equals-list
branch
October 22, 2026 19:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proofreading the conformance suite against
spec/HOCON.mdfound a rule no case pinned, where zig-hocon and pyhocon part ways.unquoted-strings/025-digit-initial-invalid-number:a = 1.2.31.2.3(the shape of127.0.0.1) isn't a number, so the input is an error (BadNumber).java: lenient,java_expect: {"a": "1.2.3"}. typesafe/config 1.4.9 and pyhocon both read it as a string.python/MIGRATING.mdgets what this means for a pyhocon user: an IP address needs quotes (a row in No silent guesses and a Step 3 bullet).A second case,
a += [3, 4]→[1, 2, [3, 4]], was dropped in review: it is 001's desugaring with 008's composite element, and pyhocon already fails the whole+=section, so it told no implementation apart. The pyhocon difference stays pinned inpython/tests/test_pyhocon_compat.py(#25).Docs:
FINDINGS.mdgets a short "Since then" note, and the digit-initial "uncovered" bullet says it's covered.SECTIONS.md: unquoted strings 24→25. README and MIGRATING.md: 445 of the 446.Checks
fill-expected.py --check: 446 cases, 0 sidecars stale.🤖 Generated with Claude Code
https://claude.ai/code/session_01CbBo1aotFTDLY2gery7qYD