Repository navigation
Conversation
…llowances return to config (#225) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SjEL1LhqZs7gK6zG4STip2
Review (haiku, claude-review.yml)
No other significant problems found. The |
Triage of the Haiku review
The PR stays unarmed until three things happen: the token is re-minted, the |
terraform plan (success) |
…wer rule 2 exception, second org owner noted (#225) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SjEL1LhqZs7gK6zG4STip2
Review (haiku, claude-review.yml)Review of #351: FLEET_ADMIN_TOKEN re-minted as a classic PAT, three template-sync allowances restored PR-workflow checks pass: the body has
|
…eption and the owner convention (#225) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SjEL1LhqZs7gK6zG4STip2
terraform plan (success) |
terraform plan (failure) |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SjEL1LhqZs7gK6zG4STip2
Triage of the Haiku review of
|
terraform plan (failure) |
Review (haiku, claude-review.yml)Review of PR #351: FLEET_ADMIN_TOKEN re-minted as a classic PAT, with the template-sync allowances codified
Checks that passed on read-through: |
Closes #225.
Summary
#225 found that the fine-grained
FLEET_ADMIN_TOKENcannot resolve a GitHub App's node id. As a result, the merge gate's App allowances cannot be managed by Terraform. #224's allowance forlentago-template-syncon the three uvularia template repos failed on apply and has existed only in live state since. The maintainer chose #225's option B on 2026-11-17: re-mint the token as a classic PAT withrepoandadmin:org, minted fromcjpitzi, the org's existing second owner (account decision recorded on #225; stored 2026-11-18T02:34:29Z).This PR changes three things:
terraform/locals.tf. The threegate_extra_allowancesentries from merge gate: allow lentago-template-sync to arm auto-merge on the three uvularia template repos #224 return, and the "live only" warning is replaced by the reason they now resolve. Live state already carries the App on all three repos (read back on 2026-11-17), so the expected plan is no change to those resources.terraform/README.md§ Auth. It now gives the classic token's form: minted fromcjpitzi,repoandadmin:org, still nodelete_repo, with an expiry recorded inrenewals.yml. It also says why the token is classic and what that widens. The merge-gate section and the Phase 2 note no longer describe the old token.cpitzi" is a convention rather than an enforced rule: the gate leavesenforce_adminsoff, so any owner can pass it. Merge gate: enforce_admins so org owners can't pass the push allowlist unnamed #359 makes it enforced. Owner membership is live org state that this tree doesn't manage (Codify org settings in Terraform — default_repository_permission is live-only #176). The token reaches whatcjpitzican reach: the org, whererepois full control, and that account's own repos;admin:orgadmits org-settings writes, which this tree still never uses (Codify org settings in Terraform — default_repository_permission is live-only #176); and as a repo secret, the token is readable by a workflow on any branch here.Ordering: after #360 (#352's fix), and after the token is re-stored
The
planon this PR runs under the current fine-grained token, so it fails with "Could not resolve to a node with the global id". That failure is #225 itself, not this change. To proceed:cjpitzi(scopesrepoandadmin:org, nodelete_repo, 366-day expiry) and stores it. It was stored at 02:34:29Z, and that value was rejected with a 401, so it is being re-stored.planon this PR. Expect no changes for the threemerge_gateresources and nothing else.fleet-reports/lock-in/renewals.ymlrecords the expiry, 2027-11-19 (3c7723d).gh api repos/lentago/<repo>/branches/main/protection --jq '.restrictions.apps[].slug'.Checks
python3 ci/validate.pyandterraform fmt -checkpass locally.🤖 Generated with Claude Code
https://claude.ai/code/session_01SjEL1LhqZs7gK6zG4STip2