Skip to content

Record DEPENDABOT_MERGE_TOKEN's expiry in the renewal calendar - #356

Merged
cpitzi merged 3 commits into
mainfrom
renewals-dependabot-merge-token
Nov 18, 2026
Merged

cpitzi merged 3 commits into
mainfrom
renewals-dependabot-merge-token

Conversation

@cpitzi

@cpitzi cpitzi commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Closes #355. Part of #346.

Summary

Adds a credential-dependabot-merge-pat entry to fleet-reports/lock-in/renewals.yml, so the renewal calendar opens an issue 14 days before the Dependabot sweeper's token lapses.

The token is the fine-grained PAT that ADR-0016 Decision 3 describes. The maintainer minted it and stored it in the main-only dependabot-merge environment at 2026-11-18T02:27Z, with a 366-day expiry: 2027-11-19. The entry follows the existing credential-fleet-reports-pat entry: its name, its category, the date, and a note on how to rotate it. It carries no value or account identifier, as the file's header requires.

Checks

python3 ci/validate.py passes, and the file parses as YAML with both credential entries present.

🤖 Generated with Claude Code

https://claude.ai/code/session_01SjEL1LhqZs7gK6zG4STip2

@github-actions

Copy link
Copy Markdown
Contributor

Review (haiku, claude-review.yml)

Review: PR #356, renewal entry for DEPENDABOT_MERGE_TOKEN

  1. minor: fleet-reports/lock-in/renewals.yml:83-94. The entry names the secret DEPENDABOT_MERGE_TOKEN, and its note says the sweeper "fails fast at its token check." Nothing in this checkout references that secret name or a sweeper workflow yet (grep finds only terraform/locals.tf and ADR-0016). ADR-0016's order of work puts the sweeper after this record. The secret name and the failure behaviour can't be confirmed from the diff, so they should match the sweeper once it lands.

  2. minor: fleet-reports/lock-in/renewals.yml:80. next_due: 2027-11-19 is the only record of the token's expiry, and the diff can't check it against the token. A one-day error moves the alarm by one day, so it's worth confirming against the expiry shown in GitHub's token settings. The 366-day lifetime also sits at the edge of ADR-0016 Decision 3's "at most one year."

Checks against the requested focus areas:

  • The change is a single 14-line addition to one YAML file. It touches no Terraform, workflow, generated artifact, or brand asset.
  • The entry has no credential values or account identifiers. The note says the value is not in the file, which fits the file's public-repo rules.
  • The entry's fields match the schema in the file header, and category: credential is an existing value.
  • Fleet PR-workflow checks: the body has Closes #355, the title matches the change, the scope is one entry, and the summary covers what, why, and the constraints. The 🤖 Generated with Claude Code attribution is present.

Not verified: I could not run ci/validate.py or parse the YAML, because those commands were blocked for approval in this session. The PR body says both pass, and I have not confirmed it.

@cpitzi

cpitzi commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

Triage of the Haiku review

  1. The secret name and the fail-fast behaviour can't be confirmed from this diff. Resolved by order, no change. The sweeper (Dependabot sweeper: workflow and gate, dispatch-only dry run first (ADR-0016) #354) has since merged. .github/workflows/dependabot-sweeper.yml on main reads DEPENDABOT_MERGE_TOKEN from the dependabot-merge environment and fails at its token check when the value is empty (Dependabot sweeper: measure the token and probe auth before sweeping #358 extends that check).
  2. The date can't be checked against the token, and 366 days sits at the edge of "at most one year". No change. The maintainer stored the token at 2026-11-18T02:27Z with a 366-day expiry, and the date was relayed as 2027-11-19. The 14-day lead absorbs a one-day error. A 366-day expiry is what "at most one year" means in ADR-0016, and the date sits in this file so the calendar warns ahead of it.

@cpitzi
cpitzi enabled auto-merge (squash) November 18, 2026 02:38
@cpitzi
cpitzi merged commit 4b402c0 into main Nov 18, 2026
11 checks passed
@cpitzi
cpitzi deleted the renewals-dependabot-merge-token branch November 18, 2026 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Record DEPENDABOT_MERGE_TOKEN's expiry in the renewal calendar

1 participant