Skip to content

feat(dock): hide the dock icon when settings and setup are closed; - #8

Open
Sharad-Patel1 wants to merge 1 commit into
letsgetrusty:mainfrom
Sharad-Patel1:feat/menu-bar-dock-lifecycle
Open

Sharad-Patel1 wants to merge 1 commit into
letsgetrusty:mainfrom
Sharad-Patel1:feat/menu-bar-dock-lifecycle

Conversation

@Sharad-Patel1

Copy link
Copy Markdown

TL;DR: Murmur remained in the Dock even with its windows closed. It now runs in the menu bar, appearing in the Dock only while Settings or Setup is open.

Minimised windows/windows hidden with Cmd+H still show in the Dock and when you Cmd+Tab. Closing the last Settings/Setup window removes the Dock icon, the app still works like normal, we are just removing it from the dock. The recording overlay does not affect Dock presence.

Uses Tauri's macOS activation policies and existing window lifecycle, with main-thread transitions and agent-app startup configured for development and release builds. No new preference or production dependency.

Validation

  • 48 Rust tests passed, including two new Dock-policy tests; 4 existing tests ignored.
  • 16 frontend tests passed.
  • Clippy with warnings denied, formatting, frontend build, and Rust build passed.
  • Bundle metadata and shell syntax checks passed.
  • Native Dock, Cmd+Tab, and focus verification remains pending; manual checks are documented in docs/testing.md.

Screen recording

References

AI USAGE NOTE: Implemented with GPT-6 using the Codex harness.

@Sharad-Patel1

Sharad-Patel1 commented Sep 5, 2026 •

Copy link
Copy Markdown
Author

So, I should clarify one thing. We use the set_activation_policy because the pinned Tao version in this repo v0.35.3, the implementation of the set_dock_visibility in that version ignores hide requests within one second of showing the icon and it does not retry it. It was causing some issues when we would do a quick open/close of the window or the initial open of the app, it was leaving the icon in the dock. That method would also mess with the existing windows' canHide flags, which I didn't really want to deal with/it adds more unnecessary work for no benefit, so imo the activation policy is the best approach and avoids the bugs and the extra code we would have to implement.

Please let me know if you don't like the impl.

Ref: set_dock_hide method

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant