Skip to content

attest : remove "storage" and "volume" from the field names - #76

Draft
shjala wants to merge 1 commit into
lf-edge:mainfrom
shjala:generic_attest
Draft

shjala wants to merge 1 commit into
lf-edge:mainfrom
shjala:generic_attest

Conversation

@shjala

@shjala shjala commented Nov 27, 2024 •

Copy link
Copy Markdown
Member

Remove "storage" and "volume" from the field names, this is to make the field names more generic and not tied to storage or volume. This will make adding new keys to the attestation process easier. There has been no change in the wire format.

Rebase status — 2026-11-12

Rebased onto current main and regenerated Go/Python attestation bindings. Preserved upstream field numbers, reserved fields, binary event log, origin-version and PCR-policy additions while applying the generic key naming. New key-version names were made consistent with the rename. Go attest package compilation and Python syntax checks passed. This API rename is still absent upstream; coordinated controller/device consumer updates remain required. Keep draft.

This status describes the current rebased head; earlier CI and validation claims apply to their earlier revisions. Fresh CI is required.

@shjala
shjala requested a review from eriknordmark as a code owner November 27, 2024 18:38
Comment thread proto/attest/attest.proto Resolved
Comment thread proto/attest/attest.proto Resolved
Comment thread proto/attest/attest.proto Resolved
Comment thread proto/attest/attest.proto Resolved
@shjala
shjala force-pushed the generic_attest branch 4 times, most recently from 10acaa1 to da1c41f Compare November 28, 2024 10:23

@eriknordmark eriknordmark left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we need to coordinate these changes with the controllers so that they get the changes and no surprises that they need to do the renames in their source code.

@shjala

shjala commented Jan 3, 2025

Copy link
Copy Markdown
Member Author

LGTM but we need to coordinate these changes with the controllers so that they get the changes and no surprises that they need to do the renames in their source code.

OK, lets have this pending until I've informed the relevant developers.

@cshari-zededa

Copy link
Copy Markdown
Contributor

The best time to do this change is when we bring in a new key to the attestation scheme. There will be changes required on both the sides at that time, and we can absorb this change as well.

@shjala
shjala marked this pull request as draft November 7, 2025 09:26
Remove "storage" and "volume" from the field names, this is to make the
field names more generic and not tied to storage or volume. This will
make adding new keys to the attestation process easier.

There has been no change in the wire format.

Signed-off-by: Shahriyar Jalayeri <shahriyar@zededa.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants