Skip to content

[nvidia-gb] Fix CVE-2026-98432: defer IPv4 option frees with RCU - #329

Merged
rene merged 1 commit into
lf-edge:eve-kernel-arm64-v7.0.14-nvidia-gbfrom
rene:fix/cve-2026-98432-nvidia-gb
Nov 3, 2026
Merged

rene merged 1 commit into
lf-edge:eve-kernel-arm64-v7.0.14-nvidia-gbfrom
rene:fix/cve-2026-98432-nvidia-gb

Conversation

@rene

@rene rene commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator

Backport the upstream fix for CVE-2026-98432 (IPv4 option use-after-free) to eve-kernel-arm64-v7.0.14-nvidia-gb, matching the fix already merged on the jp5/jp6/jp7 and generic branches (#314–#325).

inet_sock_destruct() and tcp_v4_reqsk_destructor() now free inet_opt/ireq_opt with kfree_rcu() instead of kfree(), so concurrent RCU readers (SYNACK building, request socket migration) can't hit freed memory.

Upstream: torvalds/linux@e3f33b0

Clean cherry-pick -x with no conflicts; the rcu field in struct ip_options_rcu already exists in this tree.

🤖 Generated with Claude Code

tcp_v4_syn_recv_sock() transfers ownership of ireq->ireq_opt to the
child socket (newinet->inet_opt) without copying it.

Another cpu can concurrently process a retransmitted SYN for the same
request socket, and send a SYNACK from tcp_check_req().
tcp_v4_send_synack() and inet_csk_route_req() read ireq->ireq_opt
under rcu_read_lock() only, and ip_build_and_send_pkt() and
ip_options_build() then read opt->optlen twice.

Note that the SYNACK timer itself is not an issue: it holds a
reference on its request socket, and inet_csk_reqsk_queue_drop()
calls timer_delete_sync() before the child can be freed.

Since commit 079096f ("tcp/dccp: install syn_recv requests
into ehash table"), request sockets are processed without holding
the listener lock, so nothing prevents the child socket from being
freed while the SYNACK is still being built. TCP child sockets do
not have SOCK_RCU_FREE, and inet_sock_destruct() frees inet_opt
with a plain kfree(), leading to a use-after-free in
ip_options_build().

A similar issue exists with request socket migration
(net.ipv4.tcp_migrate_req=1, or a BPF_SK_REUSEPORT_SELECT_OR_MIGRATE
program). reqsk_timer_handler() clones the request socket with
inet_reqsk_clone(), so that the old request socket and its clone
share the same ireq_opt, then reqsk_migrate_reset() clears the
pointer in the old one. Another cpu holding a reference on the old
request socket can still be using these options (sending a SYNACK,
or creating a child in tcp_v4_syn_recv_sock()) when the clone is
freed, and tcp_v4_reqsk_destructor() also uses a plain kfree().

Readers already use RCU, and other paths replacing inet_opt
(do_ip_setsockopt(), cipso_v4_sock_setattr()...) already use
kfree_rcu(). Use kfree_rcu() in inet_sock_destruct() and
tcp_v4_reqsk_destructor() as well.

IPv6 is not affected by the first issue, because tcp_v6_syn_recv_sock()
duplicates the options. tcp_v6_reqsk_destructor() has the same
migration issue with ipv6_opt, which is only set by CALIPSO. This
will be addressed in a separate patch.

Fixes: 079096f ("tcp/dccp: install syn_recv requests into ehash table")
Fixes: c905dee ("tcp: Migrate TCP_NEW_SYN_RECV requests at retransmitting SYN+ACKs.")
Reported-by: Xinyang Ge <xinyang@anthropic.com>
Signed-off-by: Eric Dumazet <edumazet@kernel.org>
Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com>
Link: https://patch.msgid.link/20261001221253.2964024-1-edumazet@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
(cherry picked from commit e3f33b0a1d89d738e2b913dab519226eaf76e15b)
Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
@rene
rene requested a review from shjala November 3, 2026 11:15

@shjala shjala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rene
rene merged commit 3e304d8 into lf-edge:eve-kernel-arm64-v7.0.14-nvidia-gb Nov 3, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants