Repository navigation
evetest: list parameters declared through a helper - #6600
Merged
milan-zededa merged 2 commits intoSep 28, 2026
Merged
Conversation
eriknordmark
requested review from
christoph-zededa,
europaul,
rene and
rucoder
September 18, 2026 22:51
eriknordmark
marked this pull request as ready for review
September 18, 2026 22:51
A test whose DefineTestParameters call goes through a package-local helper advertised no parameters at all in `make list-tests`. The ten conversion tests under tests/konvert are the only ones in the tree that declare them that way, and every one of their rows was empty, so the axes they accept -- the released version the device starts on, which way a repartition must free space, why a conversion must be refused -- were invisible to anyone reading the listing. list-tests now follows a call from a test into a package-local function, binding the definitions the call site passes for that function's formal parameters, and resolves a definition list through local variables, append, slice literals, and functions returning a slice of definitions. Signed-off-by: eriknordmark <erik@zededa.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The listing told the reader that RAM_SIZE_MB and CPUS resolve to the framework's 8192 MiB and 4 vCPUs when left unset, while a test is free to raise an unset value to a floor of its own -- which the doc comment on each constructor already says. Naming the floor in the displayed default keeps the one string a user sees from promising a number that need not hold. Signed-off-by: eriknordmark <erik@zededa.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
eriknordmark
force-pushed
the
evetest-listtests-params
branch
from
September 18, 2026 23:14
7c243cc to
9bcd5b1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6600 +/- ##
==========================================
+ Coverage 26.24% 26.56% +0.31%
==========================================
Files 515 525 +10
Lines 94872 96584 +1712
==========================================
+ Hits 24902 25655 +753
- Misses 68046 68821 +775
- Partials 1924 2108 +184 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
milan-zededa
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
make list-testsis where a user learns what a test can be configuredwith. A test whose
DefineTestParameterscall goes through apackage-local helper advertised nothing at all. The ten conversion tests
under
evetest/tests/konvertare the only ones in the tree that declareparameters that way, and every one of their rows was empty, so the axes
they accept -- the released version the device starts on, which way a
repartition must free space, why a conversion must be refused -- were
invisible to anyone reading the listing.
The first commit teaches
list-teststo follow a call from a test into apackage-local function, binding the definitions the call site passes for
that function's formal parameters, and to resolve a definition list
through local variables,
append, slice literals, and functionsreturning a slice of definitions. The output diff against master is
confined to
TestKonvertSuiteand those ten tests; every other row isbyte-identical.
The second commit concerns one displayed default.
RAM_SIZE_MBandCPUSwere shown as resolving to the framework's 8192 MiB and 4 vCPUswhen left unset, while a test is free to raise an unset value to a floor
of its own -- which the doc comment on each constructor already says.
Naming the floor keeps the string a user sees from promising a number
that need not hold.
The two commits are independent; neither depends on the other.
Introduced in #6539.
How to test and validate this PR
Static analysis only -- no EVE build and no device are involved, and
nothing a test does at run time changes.
Every konvert test now carries its parameters, e.g.
and each set matches that test's own call site: the cross-flavor tests
get
ALT_EVE_VERSION, the refused testREFUSE_REASON.Covered by an automated test:
GOWORK=off go test ./cmd/list-tests/runs the resolver over a fixture package shaped like
tests/konvert(helper indirection, variadic pass-through,
append, and aslice-returning function). Against the tool as it stands on master that
test fails with
got 0 parameters [], want 3.Changelog notes
No user-facing changes.
PR Backports
list-testsexists there, but the branch has neitherthe
tests/konvertpackage nor theRAM_SIZE_MB/CPUSparameters,so neither commit has a subject on it.
Checklist
And the last but not least:
check them.
No device was used because none can be: the change is a static-analysis
CLI plus one description string, neither of which runs on a device. The
README already documents
make list-testsand the parameter mechanism,and this changes neither.
🤖 Generated with Claude Code