Repository navigation
actionlint: re-enable shellcheck - #6698
Merged
Merged
Conversation
Three steps append to GITHUB_OUTPUT one echo at a time, which shellcheck flags as SC2129. Write each set of outputs through a single grouped redirect instead; the outputs themselves are unchanged. Signed-off-by: eriknordmark <erik@zededa.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
actionlint's -shellcheck flag names the shellcheck executable, so -shellcheck=-e=SC2086,SC2046,SC2035 makes actionlint look for a binary called "-e=SC2086,SC2046,SC2035", fail to find it, and silently disable its shellcheck rule. Workflow Lint on master has not run shellcheck since that flag was added, while 17.0-stable, which never got the flag, still does. Drop the flag and exclude the three codes through ignore patterns in .github/actionlint.yaml, which is identical on master and 17.0-stable. The only shellcheck finding left on master is an info-level SC2016, which does not fail the job. Signed-off-by: eriknordmark <erik@zededa.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rene
approved these changes
Oct 5, 2026
6 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Workflow Lint on master has not run shellcheck since
actionlint_flags: -shellcheck=-e=SC2086,SC2046,SC2035was added.-shellchecknames the shellcheck executable, so actionlint looks for abinary called
-e=SC2086,SC2046,SC2035, fails to find it, and disables therule without failing (
actionlint -verboseprintsRule "shellcheck" was disabled: exec: "-e=SC2086,SC2046,SC2035": executable file not found in $PATH). 17.0-stable never got the flag, so it still runs shellcheck. That iswhy the
pr-gate.ymlbackport #6692 fails Workflow Lint on three SC2129findings that the identical file passes on master.
This PR moves the three exclusions to
ignore:patterns in.github/actionlint.yaml, which is identical on master and 17.0-stable, anddrops the flag. The reviewdog action maps shellcheck's
styleseverity toerror, so the three SC2129s inpr-gate.ymlwould then fail the next PRthat touches it. The first commit fixes them by grouping each step's writes
to
GITHUB_OUTPUTinto one redirect. The outputs are unchanged.How to test and validate this PR
Use actionlint 1.7.12 from
ghcr.io/reviewdog/action-actionlint:v1.72.0, theimage this job runs, across the whole
.githubtree:action's
/entrypoint.shrun withfail_level: errorexits 0.pr-gate.yml: the same run reportsthe three SC2129s and exits 1, so the re-enabled rule fails where it
should.
Changelog notes
None. CI tooling only.
PR Backports
actionlint.yamlpart of the second applies; that branch has no
actionlint_flags). Thepr-gate.ymlcommit unblocks [17.0-stable] pr-gate: fix PR identification behind a finished build #6692.pr-gate.ymlcommit only, to keep that file identical tomaster's ([16.0-stable] pr-gate: fix PR identification behind a finished build #6693). The branch has no Workflow Lint.
pr-gate.ymlcommit only ([14.5-stable] pr-gate: fix PR identification behind a finished build #6694). The branch has no Workflow Lint.pr-gate.ymlcommit only ([13.4-stable] pr-gate: fix PR identification behind a finished build #6695). The branch has no Workflow Lint.Checklist
And the last but not least:
check them.
Device testing does not apply: the change touches GitHub Actions workflows
and lint configuration only.
🤖 Generated with Claude Code