Skip to content

actionlint: re-enable shellcheck - #6698

Merged
rene merged 2 commits into
lf-edge:masterfrom
eriknordmark:actionlint-shellcheck
Oct 5, 2026
Merged

rene merged 2 commits into
lf-edge:masterfrom
eriknordmark:actionlint-shellcheck

Conversation

@eriknordmark

Copy link
Copy Markdown
Contributor

Description

Workflow Lint on master has not run shellcheck since
actionlint_flags: -shellcheck=-e=SC2086,SC2046,SC2035 was added.
-shellcheck names the shellcheck executable, so actionlint looks for a
binary called -e=SC2086,SC2046,SC2035, fails to find it, and disables the
rule without failing (actionlint -verbose prints Rule "shellcheck" was disabled: exec: "-e=SC2086,SC2046,SC2035": executable file not found in $PATH). 17.0-stable never got the flag, so it still runs shellcheck. That is
why the pr-gate.yml backport #6692 fails Workflow Lint on three SC2129
findings that the identical file passes on master.

This PR moves the three exclusions to ignore: patterns in
.github/actionlint.yaml, which is identical on master and 17.0-stable, and
drops the flag. The reviewdog action maps shellcheck's style severity to
error, so the three SC2129s in pr-gate.yml would then fail the next PR
that touches it. The first commit fixes them by grouping each step's writes
to GITHUB_OUTPUT into one redirect. The outputs are unchanged.

How to test and validate this PR

Use actionlint 1.7.12 from ghcr.io/reviewdog/action-actionlint:v1.72.0, the
image this job runs, across the whole .github tree:

  • With this PR: one info-level SC2016, which does not fail the job. The
    action's /entrypoint.sh run with fail_level: error exits 0.
  • With this PR's config but the unfixed pr-gate.yml: the same run reports
    the three SC2129s and exits 1, so the re-enabled rule fails where it
    should.

Changelog notes

None. CI tooling only.

PR Backports

Checklist

  • I've provided a proper description
  • I've added the proper documentation
  • I've tested my PR on amd64 device
  • I've tested my PR on arm64 device
  • I've written the test verification instructions
  • I've set the proper labels to this PR

And the last but not least:

  • I've checked the boxes above, or I've provided a good reason why I didn't
    check them.

Device testing does not apply: the change touches GitHub Actions workflows
and lint configuration only.

🤖 Generated with Claude Code

eriknordmark and others added 2 commits October 2, 2026 11:28
Three steps append to GITHUB_OUTPUT one echo at a time, which
shellcheck flags as SC2129. Write each set of outputs through a
single grouped redirect instead; the outputs themselves are
unchanged.

Signed-off-by: eriknordmark <erik@zededa.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
actionlint's -shellcheck flag names the shellcheck executable, so
-shellcheck=-e=SC2086,SC2046,SC2035 makes actionlint look for a binary
called "-e=SC2086,SC2046,SC2035", fail to find it, and silently
disable its shellcheck rule. Workflow Lint on master has not run
shellcheck since that flag was added, while 17.0-stable, which never
got the flag, still does.

Drop the flag and exclude the three codes through ignore patterns in
.github/actionlint.yaml, which is identical on master and 17.0-stable.
The only shellcheck finding left on master is an info-level SC2016,
which does not fail the job.

Signed-off-by: eriknordmark <erik@zededa.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rene
rene merged commit 1548900 into lf-edge:master Oct 5, 2026
20 of 21 checks passed
@eriknordmark
eriknordmark deleted the actionlint-shellcheck branch October 8, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants